You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/29 23:00:51 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

dongjoon-hyun opened a new pull request #30190:
URL: https://github.com/apache/spark/pull/30190


   ### What changes were proposed in this pull request?
   
   This PR aims to wrap `ArrayBasedMapData` literal representation with `map(...)`.
   
   ### Why are the changes needed?
   
   Literal ArrayBasedMapData has inconsistent string representation from `LogicalPlan` to `Optimized Logical Plan/Physical Plan`. Also, the representation at `Optimized Logical Plan` and `Physical Plan` is ambiguous like `keys: [key1], values: [value1] AS c#0`.
   
   ```
   scala> spark.version
   res0: String = 2.4.7
   
   scala> sql("SELECT map('key1', 'value1') c").explain(true)
   == Parsed Logical Plan ==
   'Project ['map(key1, value1) AS c#0]
   +- OneRowRelation
   
   == Analyzed Logical Plan ==
   c: map<string,string>
   Project [map(key1, value1) AS c#0]
   +- OneRowRelation
   
   == Optimized Logical Plan ==
   Project [keys: [key1], values: [value1] AS c#0]
   +- OneRowRelation
   
   == Physical Plan ==
   *(1) Project [keys: [key1], values: [value1] AS c#0]
   +- Scan OneRowRelation[]
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. This changes the query plan's string representation in `explain` command and UI.
   
   ### How was this patch tested?
   
   Pass the CI with the newly added test case.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719097132


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35023/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719073324


   **[Test build #130419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130419/testReport)** for PR 30190 at commit [`0fea5a9`](https://github.com/apache/spark/commit/0fea5a9cb9ad9a6e441ad5789772dbed410238f4).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719104729






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30190:
URL: https://github.com/apache/spark/pull/30190#discussion_r514646838



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -297,6 +297,7 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
   override def toString: String = value match {
     case null => "null"
     case binary: Array[Byte] => s"0x" + DatatypeConverter.printHexBinary(binary)
+    case d: ArrayBasedMapData => s"map(${d.toString})"

Review comment:
       Just a question; any reason not to update `ArrayBasedMapData#toString` instead?
   https://github.com/apache/spark/blob/cbd3fdea62dab73fc4a96702de8fd1f07722da66/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala#L35-L37




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719159450






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] viirya commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719104012


   
   Seems it is still inconsistent between Logical Plan and Optimized Logical Plan? Although it is better after this change.
   
   ```scala
   == Analyzed Logical Plan ==
   a: int, b: map<string,string>
   Project [1 AS a#4, map(key1, value1) AS b#5]
   +- OneRowRelation
   
   == Optimized Logical Plan ==
   Project [1 AS a#4, map(keys: [key1], values: [value1]) AS b#5]
   +- OneRowRelation
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30190:
URL: https://github.com/apache/spark/pull/30190#discussion_r514647947



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -297,6 +297,7 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
   override def toString: String = value match {
     case null => "null"
     case binary: Array[Byte] => s"0x" + DatatypeConverter.printHexBinary(binary)
+    case d: ArrayBasedMapData => s"map(${d.toString})"

Review comment:
       The **static literal map**'s string representation happens to be `ArrayBasedMapData` for now, but it can be changed later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30190:
URL: https://github.com/apache/spark/pull/30190


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30190:
URL: https://github.com/apache/spark/pull/30190#discussion_r514647529



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -297,6 +297,7 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
   override def toString: String = value match {
     case null => "null"
     case binary: Array[Byte] => s"0x" + DatatypeConverter.printHexBinary(binary)
+    case d: ArrayBasedMapData => s"map(${d.toString})"

Review comment:
       Yes. It's because that class is `MapData` technically, not `Map`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719104729


   Yes. That's intentional because it's `ArrayBasedMapData`. This PR didn't want to change `ArrayBasedMapData`. The main point is **grouping** with `map(...)` to remove disambiguity when we attached `#5`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719127133


   Merged to master/3.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719073324


   **[Test build #130419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130419/testReport)** for PR 30190 at commit [`0fea5a9`](https://github.com/apache/spark/commit/0fea5a9cb9ad9a6e441ad5789772dbed410238f4).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719158764


   **[Test build #130419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130419/testReport)** for PR 30190 at commit [`0fea5a9`](https://github.com/apache/spark/commit/0fea5a9cb9ad9a6e441ad5789772dbed410238f4).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719097147






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30190:
URL: https://github.com/apache/spark/pull/30190#discussion_r514647947



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -297,6 +297,7 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
   override def toString: String = value match {
     case null => "null"
     case binary: Array[Byte] => s"0x" + DatatypeConverter.printHexBinary(binary)
+    case d: ArrayBasedMapData => s"map(${d.toString})"

Review comment:
       The **static literal map**'s string representation happens to be `ArrayBasedMapData` for now, but it was just one of design choice and can be changed later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719090150


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35023/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719101549


   Could you review this please, @viirya and @maropu ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719159450






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719104729


   Yes, @viirya . That's intentional because it's `ArrayBasedMapData`. This PR didn't want to change `ArrayBasedMapData`. The main point is **grouping** with `map(...)` to remove disambiguity when we attached `#5`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719126591


   Thank you, @maropu and @viirya !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30190:
URL: https://github.com/apache/spark/pull/30190#discussion_r514647947



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -297,6 +297,7 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
   override def toString: String = value match {
     case null => "null"
     case binary: Array[Byte] => s"0x" + DatatypeConverter.printHexBinary(binary)
+    case d: ArrayBasedMapData => s"map(${d.toString})"

Review comment:
       The **static map**'s `Literal` representation happens to be `ArrayBasedMapData` for now, but it can be changed later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719104729


   Yes. That's intentional because it's `ArrayBasedMapData`. This PR didn't want to change `ArrayBasedMapData`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719097147






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719127133


   Merged to master/3.0/2.4.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on pull request #30190: [SPARK-33292][SQL] Make Literal ArrayBasedMapData string representation disambiguous

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30190:
URL: https://github.com/apache/spark/pull/30190#issuecomment-719117239


   > The main point is grouping with map(...) to remove disambiguity when we attached #5.
   
   This update seems fine to me. But, as @viirya suggested above, since consistent string forms for maps looks better, I also think it might be worth fixing it in future work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org