[GitHub] [incubator-superset] ktmud commented on issue #9935: [SIP-45] Proposal for improved UX for dashboard filter eligibility

[GitBox <gi...@apache.org>]

ktmud commented on issue #9935:
URL: https://github.com/apache/incubator-superset/issues/9935#issuecomment-670633621


   Based on previous offline discussions with @graceguo-supercat and @john-bodley, here's what needs to be done in the near term:
   
   ### 1. Present more accurate filter indicators for charts
   
   Pass all in-scope filter fields and values to charts (together with the `extraFilers` field), the chart slice API returns whether a field is valid (exists in datasource) or not (could be another field `activeFilers` in the payload). The frontend then have a way to display only actual `activeFilers` for a chart.
   
   ### 2. Clarify applicable scopes for filters in filter scope editor modal
   
   We could take either approach below:
   
   1. Add a help text explaining filters can only apply to charts whose datasources have corresponding fields
   2. (Optional) Create an endpoint that given a list of filter field names and charts returns applicable charts for each filter field. The backend will query database schema for all associated charts and check whether they contain columns that match the filter fields. The the frontend will use this information to disable any charts in the filter scope tree that do not match certain filter.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org