You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2024/06/11 08:45:16 UTC

[PR] chore: Make DFSchema::datatype_is_logically_equal function public [datafusion]

advancedxy opened a new pull request, #10867:
URL: https://github.com/apache/datafusion/pull/10867

   ## Which issue does this PR close?
   Follow-up on #10031
   
   ## Rationale for this change
   As discussed in https://github.com/apache/datafusion/pull/10031#discussion_r1561945088, a followup PR to make
   the function `datatype_is_logically_equal` in DFSchema public and reuses in the in_list code.
   
   ## What changes are included in this PR?
   1. make `datatype_is_logically_equal` public in DFSchema
   2. remove duplicate code in `in_list`
   
   ## Are these changes tested?
   Existing tests.
   
   ## Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] chore: Make DFSchema::datatype_is_logically_equal function public [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #10867:
URL: https://github.com/apache/datafusion/pull/10867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] chore: Make DFSchema::datatype_is_logically_equal function public [datafusion]

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #10867:
URL: https://github.com/apache/datafusion/pull/10867#issuecomment-2160145335

   @comphead @alamb it would be great if you can take a look at this when you are free.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org