You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Hanifi Gunes <hg...@maprtech.com> on 2015/03/02 22:47:45 UTC
Re: Review Request 30313: Fixing Mongo join issue when * is selected
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30313/#review74825
-----------------------------------------------------------
Overall looks good. We can go ahead and merge this in once we address these issues.
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
<https://reviews.apache.org/r/30313/#comment121609>
this is unneeded. see #setColumns.
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
<https://reviews.apache.org/r/30313/#comment121611>
As a minor comment, I think the old way of externalizing the doc string was cleaner here.
- Hanifi Gunes
On Feb. 28, 2015, 3:15 p.m., Kamesh B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30313/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2015, 3:15 p.m.)
>
>
> Review request for drill, Jacques Nadeau and Jinfeng Ni.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Fixing Mongo join issue when * is selected.
>
>
> Diffs
> -----
>
> contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java da9670154e38b6248e826b03dd71ec396ddef5f4
>
> Diff: https://reviews.apache.org/r/30313/diff/
>
>
> Testing
> -------
>
> Tested the patch by selecting * in join operation. It is working fine. This patch also fixes some of issues caused by earlier commits.
>
>
> Thanks,
>
> Kamesh B
>
>