You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sandip-db (via GitHub)" <gi...@apache.org> on 2023/10/03 14:57:11 UTC

[PR] [SPARK-45399][SQL] XML: Add XML Options using newOption [spark]

sandip-db opened a new pull request, #43201:
URL: https://github.com/apache/spark/pull/43201

   ### What changes were proposed in this pull request?
   Add XML Options using `DataSourceOptions::newOption`
   
   Also, removed legacy date and timestamp support as these are not applicable to newly introduced XML data source.
   
   ### Why are the changes needed?
   Consistency with other formats like json and csv.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   XML unit tests and github action
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45399][SQL] XML: Add XML Options using newOption [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43201:
URL: https://github.com/apache/spark/pull/43201#issuecomment-1745887413

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45399][SQL] XML: Add XML Options using newOption [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43201: [SPARK-45399][SQL] XML: Add XML Options using newOption
URL: https://github.com/apache/spark/pull/43201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org