[GitHub] [orc] wgtmac commented on a diff in pull request #1587: ORC-1481: [C++] Better error message when TZDB is unavailable

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #1587:
URL: https://github.com/apache/orc/pull/1587#discussion_r1296024801


##########
c++/src/Timezone.cc:
##########
@@ -675,6 +675,13 @@ namespace orc {
     if (itr != timezoneCache.end()) {
       return *(itr->second).get();
     }
+    if (!std::filesystem::exists(std::filesystem::path(filename))) {
+      std::stringstream ss;
+      ss << "Time zone file " << filename << " does not exist."
+         << " Please install IANA time zone database and set TZDIR env properly"

Review Comment:
   What about this: `Please install IANA time zone database and set TZDIR env if it is not installed at /usr/share/zoneinfo`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org