You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/24 10:59:12 UTC

[GitHub] [camel-k] makandre opened a new issue #1712: Ability to set labels on knative service (for things like "cluster-local")

makandre opened a new issue #1712:
URL: https://github.com/apache/camel-k/issues/1712


   For `from("knative:type/name")` routes, we need ability to configure it so that the knative service that it creates would have certain labels. Particularly, need a way to apply `serving.knative.dev/visibility=cluster-local` label so my service would not be exposed publicly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] vassilvk commented on issue #1712: Ability to set labels on knative service (for things like "cluster-local")

Posted by GitBox <gi...@apache.org>.
vassilvk commented on issue #1712:
URL: https://github.com/apache/camel-k/issues/1712#issuecomment-713130338


   @makandre, as a workaround you can create a [KubeMod](https://github.com/kubemod/kubemod) `ModRule` to intercept the service as is being created by the operator and inject the necessary labels.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] makandre edited a comment on issue #1712: Ability to set labels on knative service (for things like "cluster-local")

Posted by GitBox <gi...@apache.org>.
makandre edited a comment on issue #1712:
URL: https://github.com/apache/camel-k/issues/1712#issuecomment-698277631


   Workaround suggested by @nicolaferraro is to run with `--label serving.knative.dev/visibility=cluster-local -t owner.target-labels=serving.knative.dev/visibility`
   
   But it doesn't seem to work, the label is applied but getting this error:
   
   ```
   Revision creation failed with message: admission webhook
   "validation.webhook.serving.knative.dev" denied the request: validation
   failed: invalid key name "serving.knative.dev/visibility":
   metadata.labels.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] github-actions[bot] commented on issue #1712: Ability to set labels on knative service (for things like "cluster-local")

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1712:
URL: https://github.com/apache/camel-k/issues/1712#issuecomment-994157824


   This issue has been automatically marked as stale due to 90 days of inactivity. 
   It will be closed if no further activity occurs within 15 days.
   If you think that’s incorrect or the issue should never stale, please simply write any comment.
   Thanks for your contributions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] makandre commented on issue #1712: Ability to set labels on knative service (for things like "cluster-local")

Posted by GitBox <gi...@apache.org>.
makandre commented on issue #1712:
URL: https://github.com/apache/camel-k/issues/1712#issuecomment-698277631


   Workaround suggested by @nicolaferraro is to run with `--label serving.knative.dev/visibility=cluster-local -t owner.target-labels=serving.knative.dev/visibility`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] makandre commented on issue #1712: Ability to set labels on knative service (for things like "cluster-local")

Posted by GitBox <gi...@apache.org>.
makandre commented on issue #1712:
URL: https://github.com/apache/camel-k/issues/1712#issuecomment-698277631


   Workaround suggested by @nicolaferraro is to run with `--label serving.knative.dev/visibility=cluster-local -t owner.target-labels=serving.knative.dev/visibility`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] vassilvk edited a comment on issue #1712: Ability to set labels on knative service (for things like "cluster-local")

Posted by GitBox <gi...@apache.org>.
vassilvk edited a comment on issue #1712:
URL: https://github.com/apache/camel-k/issues/1712#issuecomment-713130338


   @makandre, as a workaround you can create a [KubeMod](https://github.com/kubemod/kubemod) `ModRule` to intercept the service as it is being created by the operator and inject the necessary labels.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] makandre edited a comment on issue #1712: Ability to set labels on knative service (for things like "cluster-local")

Posted by GitBox <gi...@apache.org>.
makandre edited a comment on issue #1712:
URL: https://github.com/apache/camel-k/issues/1712#issuecomment-698277631


   Workaround suggested by @nicolaferraro is to run with `--label serving.knative.dev/visibility=cluster-local -t owner.target-labels=serving.knative.dev/visibility`
   
   But it doesn't seem to work, the label is applied but getting this error:
   
   ```
   Revision creation failed with message: admission webhook
   "validation.webhook.serving.knative.dev" denied the request: validation
   failed: invalid key name "serving.knative.dev/visibility":
   metadata.labels.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org