You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/30 14:18:59 UTC

[GitHub] [spark] peter-toth commented on pull request #29902: [SPARK-32723][WEBUI] Upgrade to jQuery 3.5.1

peter-toth commented on pull request #29902:
URL: https://github.com/apache/spark/pull/29902#issuecomment-701421543


   > BTW, are you saying that there is no change according to the following guideline?
   > 
   > * https://jquery.com/upgrade-guide/3.5/
   
   Yes, I checked that guide and looked for self-closing HTML tags that should have content (e.g. `<p/>`, `<span/>`, `<div/>`) and I didn't found any in our UI code. They occur a few times in `dataTables` library code, but I checked our UI (Spark UI, History Server UI) and didn't find any issue.
   
   I found quite a few `<p/>`-s in the our docs and I'm checking now if those can be an issue...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org