You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/12/18 12:28:18 UTC
[GitHub] zeppelin pull request #2707: [ZEPPELIN-3100] Upgrade node and npm version
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/2707
[ZEPPELIN-3100] Upgrade node and npm version
### What is this PR for?
Reducing total build time
### What type of PR is it?
[Improvement]
### Todos
* [x] - Upgrade node and npm version
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3100
### Screenshots (if appropriate)
Before:
<img width="378" alt="screen shot 2017-12-11 at 5 57 46 pm" src="https://user-images.githubusercontent.com/3612566/34105762-effa5f8c-e438-11e7-8290-952028e47133.png">
After:
<img width="378" alt="screen shot 2017-12-11 at 5 57 46 pm" src="https://user-images.githubusercontent.com/3612566/34106082-347d7e9a-e43a-11e7-9192-a028cacc1d33.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3100
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2707.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2707
----
commit f2697c14f8726d2b9d1657dedfd1978021595d67
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-12-18T02:56:45Z
Upgraded node and npm version to reduce build time of web
commit 3312c2d2bf770bdb937883d288c4e8cb60ee22f8
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-12-18T03:14:44Z
Fixed rat
----
---
[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2707
I see, Thanks. LGTM
---
[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2707
I was tested. Looks good :)
Lgtm
---
[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2707
@1ambda Can you review it? It's kind of your idea :-)
---
[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2707
@felixcheung Yes, yarn is faster than npm4 but recently, npm5 is much faster than yarn. FE moves so fast :-)
---
[GitHub] zeppelin pull request #2707: [ZEPPELIN-3100] Upgrade node and npm version
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2707
---
[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2707
This is generated by npm v5 and it would not be changed until we change
dependencies. If it doesn't exist, npm creates it again when it runs
scripts. So adding it helps to reduce whole build time.
On Tue, 19 Dec 2017 at 7:57 AM Jeff Zhang <no...@github.com> wrote:
> *@zjffdu* commented on this pull request.
> ------------------------------
>
> In zeppelin-web/package-lock.json
> <https://github.com/apache/zeppelin/pull/2707#discussion_r157623669>:
>
> > @@ -0,0 +1,11751 @@
> +{
>
> Is this a necessary change ? Would version upgrade involve such large
> change ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zeppelin/pull/2707#pullrequestreview-84297101>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADcflpBVnfgv-nEDYz6bpJJ9RhzrXXVWks5tBu3BgaJpZM4RFZdX>
> .
>
--
이종열, Jongyoul Lee, 李宗烈
http://madeng.net
---