You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/05/15 10:42:02 UTC
[GitHub] [incubator-hugegraph] seagle-yuan opened a new pull request, #1881: fix protobuf Checkstyle
seagle-yuan opened a new pull request, #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881
move Generated java file from src/main/java to src/protobuf/java
add proto maven plugin
add proto dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1881: fix protobuf Checkstyle
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881#discussion_r875732866
##########
hugegraph-core/pom.xml:
##########
@@ -192,6 +192,24 @@
<version>0.11.2</version>
<scope>runtime</scope>
</dependency>
+
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ </dependency>
Review Comment:
do we include it in `commons-rpc` module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] seagle-yuan commented on a diff in pull request #1881: fix protobuf Checkstyle
Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on code in PR #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881#discussion_r889507438
##########
hugegraph-core/pom.xml:
##########
@@ -192,6 +192,24 @@
<version>0.11.2</version>
<scope>runtime</scope>
</dependency>
+
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ </dependency>
Review Comment:
1、I compile protobuf with different version. and found that old file compliled with likely 2.6.1 version. this version released in Apr, 2015.
https://mvnrepository.com/artifact/com.google.protobuf/protoc
2、if we add protobuf plugin. and generate file to src/protobuf/java path. this path will be ignored to check
3、Through the dependency check, found these dependencies already exist.
```
[INFO] com.baidu.hugegraph:hugegraph-rpc:jar:2.0.1:compile
[INFO] +- com.lmax:disruptor:jar:3.3.7:compile
[INFO] \- com.alipay.sofa:sofa-rpc-all:jar:5.7.6:compile
[INFO] +- com.alipay.sofa:tracer-core:jar:3.0.8:compile
[INFO] | +- io.opentracing:opentracing-api:jar:0.22.0:compile
[INFO] | +- io.opentracing:opentracing-noop:jar:0.22.0:compile
[INFO] | +- io.opentracing:opentracing-mock:jar:0.22.0:compile
[INFO] | \- io.opentracing:opentracing-util:jar:0.22.0:compile
[INFO] +- com.alipay.sofa.lookout:lookout-api:jar:1.4.1:compile
[INFO] +- io.swagger:swagger-core:jar:1.5.18:compile
[INFO] | +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.9.3:compile
[INFO] | +- io.swagger:swagger-models:jar:1.5.18:compile
[INFO] | | \- io.swagger:swagger-annotations:jar:1.5.18:compile
[INFO] | \- javax.validation:validation-api:jar:1.1.0.Final:compile
[INFO] +- io.grpc:grpc-netty-shaded:jar:1.28.0:compile
[INFO] | \- io.grpc:grpc-core:jar:1.28.0:compile (version selected from constraint [1.28.0,1.28.0])
[INFO] | +- io.grpc:grpc-api:jar:1.28.0:compile (version selected from constraint [1.28.0,1.28.0])
[INFO] | | \- io.grpc:grpc-context:jar:1.28.0:compile
[INFO] | +- com.google.code.gson:gson:jar:2.8.6:compile
[INFO] | +- com.google.android:annotations:jar:4.1.1.4:compile
[INFO] | \- io.perfmark:perfmark-api:jar:0.19.0:compile
[INFO] +- io.grpc:grpc-protobuf:jar:1.6.1:provided
[INFO] | +- com.google.protobuf:protobuf-java-util:jar:3.3.1:provided
[INFO] | +- com.google.api.grpc:proto-google-common-protos:jar:0.1.9:provided
[INFO] | \- io.grpc:grpc-protobuf-lite:jar:1.6.1:provided
[INFO] \- io.grpc:grpc-stub:jar:1.6.1:provided
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1881: fix protobuf Checkstyle
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881#discussion_r889999406
##########
pom.xml:
##########
@@ -106,7 +106,12 @@
<metrics.version>4.2.4</metrics.version>
<javassist.version>3.21.0-GA</javassist.version>
<shell-executable>bash</shell-executable>
- <checkstyle.version>3.1.2</checkstyle.version>
+ <checkstyle.plugin.version>3.1.2</checkstyle.plugin.version>
+ <checkstyle.version>8.45</checkstyle.version>
+ <hugegraph-rpc.version>2.0.1</hugegraph-rpc.version>
+ <hugegraph-common.version>2.1.2</hugegraph-common.version>
Review Comment:
todo: we need use a unify version for rpc & common (or just include commons package maybe)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1881: fix protobuf Checkstyle
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881#discussion_r873622469
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftBackendStore.java:
##########
@@ -114,7 +113,7 @@ public void init() {
public void clear(boolean clearSpace) {
byte value = clearSpace ? (byte) 1 : (byte) 0;
byte[] bytes = StoreCommand.wrap(value);
- this.submitAndWait(StoreAction.CLEAR, bytes);
+ this.submitAndWait(RaftRequests.StoreAction.CLEAR, bytes);
Review Comment:
prefer to keep StoreAction.CLEAR since it's more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] coderzc merged pull request #1881: fix protobuf Checkstyle
Posted by GitBox <gi...@apache.org>.
coderzc merged PR #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1881: fix protobuf Checkstyle
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881#issuecomment-1126907575
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1881](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (66b10ca) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/bb88c369768b381598e50a3ca3f2bfc3e0fd09f5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb88c36) will **decrease** coverage by `16.45%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #1881 +/- ##
=============================================
- Coverage 66.89% 50.43% -16.46%
+ Complexity 728 659 -69
=============================================
Files 449 449
Lines 38116 38364 +248
Branches 5404 5499 +95
=============================================
- Hits 25496 19349 -6147
- Misses 10104 16893 +6789
+ Partials 2516 2122 -394
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hugegraph/backend/store/raft/RaftBackendStore.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9SYWZ0QmFja2VuZFN0b3JlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...h/backend/store/raft/RaftBackendStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9SYWZ0QmFja2VuZFN0b3JlUHJvdmlkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...graph/backend/store/raft/RaftGroupManagerImpl.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9SYWZ0R3JvdXBNYW5hZ2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ugegraph/backend/store/raft/RaftSharedContext.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9SYWZ0U2hhcmVkQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...idu/hugegraph/backend/store/raft/StoreCommand.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9TdG9yZUNvbW1hbmQuamF2YQ==) | `0.00% <0.00%> (-58.63%)` | :arrow_down: |
| [...ugegraph/backend/store/raft/StoreStateMachine.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9TdG9yZVN0YXRlTWFjaGluZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...aph/backend/store/raft/rpc/ListPeersProcessor.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9ycGMvTGlzdFBlZXJzUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...hugegraph/backend/store/raft/rpc/RpcForwarder.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9ycGMvUnBjRm9yd2FyZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...aph/backend/store/raft/rpc/SetLeaderProcessor.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9ycGMvU2V0TGVhZGVyUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../backend/store/raft/rpc/StoreCommandProcessor.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9ycGMvU3RvcmVDb21tYW5kUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [163 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bb88c36...66b10ca](https://codecov.io/gh/apache/incubator-hugegraph/pull/1881?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] seagle-yuan commented on a diff in pull request #1881: fix protobuf Checkstyle
Posted by GitBox <gi...@apache.org>.
seagle-yuan commented on code in PR #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881#discussion_r889507438
##########
hugegraph-core/pom.xml:
##########
@@ -192,6 +192,24 @@
<version>0.11.2</version>
<scope>runtime</scope>
</dependency>
+
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ </dependency>
Review Comment:
1、I compiled protobuf with different version. and found that old file compliled with likely 2.6.1 version. this version released in Apr, 2015.
https://mvnrepository.com/artifact/com.google.protobuf/protoc
2、if we add protobuf plugin. and generate file to src/protobuf/java path. this path will be ignored to check
3、Through the dependency check, found these dependencies already exist.
```
[INFO] com.baidu.hugegraph:hugegraph-rpc:jar:2.0.1:compile
[INFO] +- com.lmax:disruptor:jar:3.3.7:compile
[INFO] \- com.alipay.sofa:sofa-rpc-all:jar:5.7.6:compile
[INFO] +- com.alipay.sofa:tracer-core:jar:3.0.8:compile
[INFO] | +- io.opentracing:opentracing-api:jar:0.22.0:compile
[INFO] | +- io.opentracing:opentracing-noop:jar:0.22.0:compile
[INFO] | +- io.opentracing:opentracing-mock:jar:0.22.0:compile
[INFO] | \- io.opentracing:opentracing-util:jar:0.22.0:compile
[INFO] +- com.alipay.sofa.lookout:lookout-api:jar:1.4.1:compile
[INFO] +- io.swagger:swagger-core:jar:1.5.18:compile
[INFO] | +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.9.3:compile
[INFO] | +- io.swagger:swagger-models:jar:1.5.18:compile
[INFO] | | \- io.swagger:swagger-annotations:jar:1.5.18:compile
[INFO] | \- javax.validation:validation-api:jar:1.1.0.Final:compile
[INFO] +- io.grpc:grpc-netty-shaded:jar:1.28.0:compile
[INFO] | \- io.grpc:grpc-core:jar:1.28.0:compile (version selected from constraint [1.28.0,1.28.0])
[INFO] | +- io.grpc:grpc-api:jar:1.28.0:compile (version selected from constraint [1.28.0,1.28.0])
[INFO] | | \- io.grpc:grpc-context:jar:1.28.0:compile
[INFO] | +- com.google.code.gson:gson:jar:2.8.6:compile
[INFO] | +- com.google.android:annotations:jar:4.1.1.4:compile
[INFO] | \- io.perfmark:perfmark-api:jar:0.19.0:compile
[INFO] +- io.grpc:grpc-protobuf:jar:1.6.1:provided
[INFO] | +- com.google.protobuf:protobuf-java-util:jar:3.3.1:provided
[INFO] | +- com.google.api.grpc:proto-google-common-protos:jar:0.1.9:provided
[INFO] | \- io.grpc:grpc-protobuf-lite:jar:1.6.1:provided
[INFO] \- io.grpc:grpc-stub:jar:1.6.1:provided
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1881: fix protobuf Checkstyle
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1881:
URL: https://github.com/apache/incubator-hugegraph/pull/1881#discussion_r889999406
##########
pom.xml:
##########
@@ -106,7 +106,12 @@
<metrics.version>4.2.4</metrics.version>
<javassist.version>3.21.0-GA</javassist.version>
<shell-executable>bash</shell-executable>
- <checkstyle.version>3.1.2</checkstyle.version>
+ <checkstyle.plugin.version>3.1.2</checkstyle.plugin.version>
+ <checkstyle.version>8.45</checkstyle.version>
+ <hugegraph-rpc.version>2.0.1</hugegraph-rpc.version>
+ <hugegraph-common.version>2.1.2</hugegraph-common.version>
Review Comment:
TODO: we need use a unify version for rpc & common (or just include commons package maybe)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org