You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/11 20:56:41 UTC

[GitHub] [beam] iindyk commented on a change in pull request #12802: Deprecate obsolete CombineFn.add_inputs.

iindyk commented on a change in pull request #12802:
URL: https://github.com/apache/beam/pull/12802#discussion_r487285999



##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -988,10 +991,14 @@ def apply(self, elements, *args, **kwargs):
       *args: Additional arguments and side inputs.
       **kwargs: Additional arguments and side inputs.
     """
+    if args or kwargs:
+      add_input = lambda accumulator, element: self.add_input(
+          accumulator, element, *args, **kwargs)
+    else:

Review comment:
       am I missing something or the else clause is not necessary?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org