You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/15 06:17:31 UTC
[GitHub] [pulsar] zymap opened a new pull request #8959: Fix the metadata setup compatibility issue
zymap opened a new pull request #8959:
URL: https://github.com/apache/pulsar/pull/8959
---
*Motivation*
#8269 change the arguments name which causes the setup
metadata command is not compatible with old versions.
For keeping the compatibility of the setup metadata command,
we should avoid deleting the existing arguments. If we need to
change it, it's better to keep the old arguments and mark it
deprecates and hide them.
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #8959: Fix the metadata setup compatibility issue
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #8959:
URL: https://github.com/apache/pulsar/pull/8959#issuecomment-787030221
@zymap @sijie I don't think we need to add `doc-required` label for this PR.
- In [PR-8269](https://github.com/apache/pulsar/pull/8269), we've added the usage for the new commands. -
- In this PR, we add the deprecated commands back in code and mark them as deprecated. So these deprecated commands can be used by existing users, yet it's encouraged to be used nor displayed in the -help list. We don't need to add usage for those deprecated commands.
What do you think about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8959: Fix the metadata setup compatibility issue
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8959:
URL: https://github.com/apache/pulsar/pull/8959#issuecomment-745154406
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #8959: Fix the metadata setup compatibility issue
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #8959:
URL: https://github.com/apache/pulsar/pull/8959#discussion_r544050590
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
##########
@@ -115,6 +115,13 @@
description = "The metadata service URI of the existing BookKeeper cluster that you want to use")
private String existingBkMetadataServiceUri;
Review comment:
Which annotation? Do you mean `@Deprecated`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #8959: Fix the metadata setup compatibility issue
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #8959:
URL: https://github.com/apache/pulsar/pull/8959#discussion_r543234514
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
##########
@@ -115,6 +115,13 @@
description = "The metadata service URI of the existing BookKeeper cluster that you want to use")
private String existingBkMetadataServiceUri;
Review comment:
This annotation is not really meaningful here by itself, can we add a comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8959: Fix the metadata setup compatibility issue
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8959:
URL: https://github.com/apache/pulsar/pull/8959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8959: Fix the metadata setup compatibility issue
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8959:
URL: https://github.com/apache/pulsar/pull/8959#issuecomment-787586850
Yes. I think we can remove the `doc-required` label for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #8959: Fix the metadata setup compatibility issue
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #8959:
URL: https://github.com/apache/pulsar/pull/8959#issuecomment-788460063
@zymap thank you for your confirmation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org