[GitHub] [netbeans] mbien commented on pull request #4205: JDK downloader improvements

[GitBox <gi...@apache.org>]

mbien commented on PR #4205:
URL: https://github.com/apache/netbeans/pull/4205#issuecomment-1150045830

   (neil)
   > A key question might be whether we should only support listing and downloading JDKs that can be registered in the running IDE? Or at least shouldn't register ones that cannot run.
   
   (emilian)
   > The default architecture pick was an interesting topic since the Apple M1s came around that time and people on M1 actually didn't have good M1 JDKs so they had to use X64 JDKs and run them through Rosetta. That's a minor concern nowadays.
   
   I thought about that too and came to same conclusion. Because in theory selecting cpu arch in a filter could be done by the IDE (default choice is already picked by the IDE). But i added the filter anyway for three reasons:
   
    - there might not always be a 1:1 mapping between JDK build and user hardware (see old 32bit builds etc)
    - its difficult to figure out what the system can actually run. For example my workstation here (64 bit linux kernel) can also run aarch64 (and more) since i have qemu configured that way. I can run aarch64 containers before deploying them to raspis or server grade arm systems. Mac + rossetta would be another example.
    - even without installing anything, the tool might be useful as simple JDK browser. ("which JDKs still run on X"). In fact, I almost wanted to add an OS combo box too (pre selected).
   
   > 
   > Maybe keep advanced as is, but we add a few options on to quick selection (eg. vendor), and possibly move to selection box over slider? The slider ran out of space hence change of min version in NB14! smile
   
   thats a good idea. I might give that a try and add it.
   
   thanks for the review @emilianbold  & @neilcsmith-net 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists