You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/02/26 22:44:53 UTC

[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #771: Improves validation of Log4j 2.x components

ppkarwasz commented on a change in pull request #771:
URL: https://github.com/apache/logging-log4j2/pull/771#discussion_r815362157



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/Builder.java
##########
@@ -42,4 +44,17 @@
      * object.
      */
     T build();
+
+    public default boolean isValid() {

Review comment:
       Corrected. I am used to put `public` also on interface methods to distiguish `public @NonNull String` from `@NonNull public String` :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org