You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/10/22 16:16:36 UTC

[GitHub] [couchdb] iilyak opened a new pull request #3227: Fix smeantics of total_rows

iilyak opened a new pull request #3227:
URL: https://github.com/apache/couchdb/pull/3227


   ## Overview
   
   The `total_rows` field suppose to be a number of documents in the database/view.
   See https://docs.couchdb.org/en/stable/api/ddoc/views.html.
   
   When new pagination API was introduced the meaning of `total_rows` field was
   changed to number of rows in the query results. The PR reverts this
   accidental change.
   
   ## Testing recommendations
   
   make check
   
   ## Related Issues or Pull Requests
   
   - https://github.com/apache/couchdb/pull/2870 - Pagination API
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] janl commented on pull request #3227: Fix semantics of total_rows

Posted by GitBox <gi...@apache.org>.
janl commented on pull request #3227:
URL: https://github.com/apache/couchdb/pull/3227#issuecomment-715374721


   +1 on fixing the accidental break


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak merged pull request #3227: Fix semantics of total_rows

Posted by GitBox <gi...@apache.org>.
iilyak merged pull request #3227:
URL: https://github.com/apache/couchdb/pull/3227


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org