You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/08 10:52:23 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #23918: [SPARK-27011] reset command fails with cache

cloud-fan commented on a change in pull request #23918: [SPARK-27011] reset command fails with cache
URL: https://github.com/apache/spark/pull/23918#discussion_r263738438
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
 ##########
 @@ -198,3 +198,6 @@ case class StreamingExplainCommand(
     ("Error occurred during query planning: \n" + cause.getMessage).split("\n").map(Row(_))
   }
 }
+
+/** Mark that the command can be skipped from cache lookup */
+trait IgnoreCachedData {}
 
 Review comment:
   can we move it to catalyst module and make it more general? I'm not sure if only commands need it
   ```
   /**
    * A [[LogicalPlan]] operator that does not use the cached results stored in CacheManager.
    */
   trait IgnoreCachedData extends LogicalPlan
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org