You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by cr...@locus.apache.org on 2000/06/12 00:18:56 UTC

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib TextareaTag.java

craigmcc    00/06/11 15:18:56

  Modified:    src/conf struts.tld
               src/share/org/apache/struts/taglib TextareaTag.java
  Log:
  Correct the TLD (and the spacing in the generated tag) for the "textarea"
  tag.  Thanks to Ralph Schaer and Kare Nuorteva for pointing out the
  problems and providing a patch.
  
  Revision  Changes    Path
  1.3       +2 -2      jakarta-struts/src/conf/struts.tld
  
  Index: struts.tld
  ===================================================================
  RCS file: /home/cvs/jakarta-struts/src/conf/struts.tld,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- struts.tld	2000/06/01 21:06:24	1.2
  +++ struts.tld	2000/06/11 22:18:55	1.3
  @@ -293,7 +293,7 @@
       <name>textarea</name>
       <tagclass>org.apache.struts.taglib.TextareaTag</tagclass>
       <attribute>
  -      <name>maxlength</name>
  +      <name>cols</name>
         <required>false</required>
         <rtexprvalue>false</rtexprvalue>
       </attribute>
  @@ -303,7 +303,7 @@
         <rtexprvalue>false</rtexprvalue>
       </attribute>
       <attribute>
  -      <name>size</name>
  +      <name>rows</name>
         <required>false</required>
         <rtexprvalue>false</rtexprvalue>
       </attribute>
  
  
  
  1.2       +4 -4      jakarta-struts/src/share/org/apache/struts/taglib/TextareaTag.java
  
  Index: TextareaTag.java
  ===================================================================
  RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/TextareaTag.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TextareaTag.java	2000/05/31 22:28:12	1.1
  +++ TextareaTag.java	2000/06/11 22:18:56	1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/TextareaTag.java,v 1.1 2000/05/31 22:28:12 craigmcc Exp $
  - * $Revision: 1.1 $
  - * $Date: 2000/05/31 22:28:12 $
  + * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/TextareaTag.java,v 1.2 2000/06/11 22:18:56 craigmcc Exp $
  + * $Revision: 1.2 $
  + * $Date: 2000/06/11 22:18:56 $
    *
    * ====================================================================
    *
  @@ -77,7 +77,7 @@
    * Custom tag for input fields of type "textarea".
    *
    * @author Craig R. McClanahan
  - * @version $Revision: 1.1 $ $Date: 2000/05/31 22:28:12 $
  + * @version $Revision: 1.2 $ $Date: 2000/06/11 22:18:56 $
    */
   
   public class TextareaTag extends BaseInputTag {
  @@ -108,7 +108,7 @@
   
   	// Create an appropriate "input" element based on our parameters
   	StringBuffer results = new StringBuffer("<textarea");
  -	results.append("name=\"");
  +	results.append(" name=\"");
   	results.append(name);
   	results.append("\"");
   	if (cols >= 0) {