You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/15 17:34:16 UTC

[GitHub] [solr] uschindler commented on pull request #18: SOLR-15261: SortedDocValues no longer extends BinaryDocValues

uschindler commented on pull request #18:
URL: https://github.com/apache/solr/pull/18#issuecomment-799609181


   I agree, some of them are completely useless to comment on or fix them: E.g. SolrDocumentFetcher is just emulating stored fields, on every call to get a virtual stored field it gets a new docvalues instance and calls advanceExact. There's no need to optimize anything here. Other places are similar, like the ChildDocTransformer. And the tests I would not care.
   
   There is room for opportunities and improvments at the other places where you sequentially read many docvalues one by one (e.g. in queries).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org