[jira] [Commented] (COLLECTIONS-859) Ambiguities in the Javadoc for PredicateUtils

["ZAID MULLA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COLLECTIONS-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18091033#comment-18091033 ] 

ZAID MULLA commented on COLLECTIONS-859:
----------------------------------------

Hi, I came across this issue and would like to work on it. I'll submit a PR to improve the Javadoc for the three {{PredicateUtils}} methods mentioned. Please assign it to me.

Thank you.

> Ambiguities in the Javadoc for PredicateUtils
> ---------------------------------------------
>
>                 Key: COLLECTIONS-859
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-859
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Daniele
>            Priority: Minor
>
> I found some ambiguities in the javadoc regarding the behavior of some methods:
> {*}PredicateUtils.nullIsExceptionPredicate(Predicate<? super T>):{*}{*}{*}
> When it says "return the predicate"  doesn't mean return the predicate parameter (args[0]), but return a new predicate that checks if the input is null and, if so, throws an exception, otherwise, delegates the evaluation to predicate (args[0]).
> *PredicateUtils.nullIsFalsePredicate(Predicate<? super T>):*
> When it says "return the predicate"  doesn't mean return the predicate parameter (args[0]), but return a new predicate that checks if the input is null and, if so, return false, otherwise, delegates the evaluation to predicate (args[0]).
> *PredicateUtils.nullIsTruePredicate(Predicate<? super T>):*
> W{*}{*}hen it says "return the predicate"  doesn't mean return the predicate parameter (args[0]), but return a new predicate that checks if the input is null and, if so, return true, otherwise, delegates the evaluation to predicate (args[0]).
> *PredicateUtils.transformedPredicate(Transformer<? super T, ? extends T>, Predicate<? super T>):*
> When it says "return the predicate"  doesn't mean return the predicate parameter (args[0]), but return a new predicate that create a predicate that transforms the input object before passing it to the predicate



--
This message was sent by Atlassian Jira
(v8.20.10#820010)