[jira] Commented: (ADFFACES-379) Configurator.endRequest fails to execute under certain conditions

["Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/ADFFACES-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473262 ] 

Jeanne Waldman commented on ADFFACES-379:
-----------------------------------------

It looks like Adam applied it to the JSF1.2 branch only. I applied this to trunk as well as requested by Scott.

> Configurator.endRequest fails to execute under certain conditions
> -----------------------------------------------------------------
>
>                 Key: ADFFACES-379
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-379
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Portlet
>         Environment: JSR-168
>            Reporter: Scott O'Bryan
>         Attachments: 13-ADFFACES-379.patch, 13-ADFFACES-379.patch
>
>
> When the filter is not run (like in a Portlet) there are certain scenarios where the Configurator.endRequest is not being called.  Looking at the implementation, there is also RequestContext initialization in Trinidad Filters and a lot of old stuff which is just muddying the waters and making the cleanup code more complex.
> We need to remove the obsolete code for RequestContext initialization in the TrinidadPhaseListener (as this is now handled by the Configurators regardless of whether the filter is run or not, and clean up handling of Configurator execution outside of the filter usecase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.