You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/02 20:34:58 UTC
[GitHub] [arrow-datafusion] Igosuki opened a new pull request #1733: Arrow2 test fix
Igosuki opened a new pull request #1733:
URL: https://github.com/apache/arrow-datafusion/pull/1733
# Which issue does this PR close?
None
# Rationale for this change
Stop using git repo for arrow2 and use a stabilized version
# What changes are included in this PR?
Use arrow2 0.9 instead of master, integrate latest datafusion and a few cosmetic changes to make future merges easier.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1733: Arrow2 test fix
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #1733:
URL: https://github.com/apache/arrow-datafusion/pull/1733#discussion_r798243703
##########
File path: datafusion/src/physical_plan/expressions/cast.rs
##########
@@ -105,6 +105,7 @@ pub fn cast_with_error(
) -> Result<Box<dyn Array>> {
let result = cast::cast(array, cast_type, options)?;
if result.null_count() != array.null_count() {
+ println!("{result:?} : {array:?}");
Review comment:
left over debug print?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1733: Arrow2 test fix
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1733:
URL: https://github.com/apache/arrow-datafusion/pull/1733#issuecomment-1033070206
I don't see any reason not to merge this into the arrow2 branch! ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Igosuki commented on pull request #1733: Arrow2 test fix
Posted by GitBox <gi...@apache.org>.
Igosuki commented on pull request #1733:
URL: https://github.com/apache/arrow-datafusion/pull/1733#issuecomment-1028947153
Fixed the parquet tests as well as some of the decimal tests. The rest of the failures are due to weird behavior when casting decimals...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Igosuki commented on a change in pull request #1733: Arrow2 test fix
Posted by GitBox <gi...@apache.org>.
Igosuki commented on a change in pull request #1733:
URL: https://github.com/apache/arrow-datafusion/pull/1733#discussion_r798325459
##########
File path: datafusion/src/physical_plan/expressions/cast.rs
##########
@@ -105,6 +105,7 @@ pub fn cast_with_error(
) -> Result<Box<dyn Array>> {
let result = cast::cast(array, cast_type, options)?;
if result.null_count() != array.null_count() {
+ println!("{result:?} : {array:?}");
Review comment:
> Left one minor comment, the rest looks good to me. Thanks @Igosuki for this work. Sorry that I wasn't able to help with the migration last weekend because something urgent came up :(
Np, I'm actually fixing some of the issues in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1733: Arrow2 test fix
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1733:
URL: https://github.com/apache/arrow-datafusion/pull/1733#issuecomment-1030744282
Float to decimal failure is caused by upstream bug, I will send a PR to get it fixed shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1733: Arrow2 test fix
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1733:
URL: https://github.com/apache/arrow-datafusion/pull/1733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org