You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by egorklimov <gi...@git.apache.org> on 2018/10/17 12:06:22 UTC
[GitHub] zeppelin pull request #3205: [ZEPPELIN-3814] Add apply button to table setti...
GitHub user egorklimov opened a pull request:
https://github.com/apache/zeppelin/pull/3205
[ZEPPELIN-3814] Add apply button to table settings
### What is this PR for?
Now changes in table settings applies only after page refreshing which isn't convenient
* Settings menu before PR:

* Menu with new button:

### What type of PR is it?
Improvement
### What is the Jira issue?
* issue - https://issues.apache.org/jira/browse/ZEPPELIN-3814
### How should this be tested?
* CI pass
* Manually tested
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17956
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3205
----
commit e9b5d11813aa15b0eedb5387d67594bd7195aed6
Author: George Klimov <kl...@...>
Date: 2018-10-10T13:13:26Z
button added
----
---
[GitHub] zeppelin issue #3205: [ZEPPELIN-3814] Add apply button to table settings
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3205
I decided to put floppy icon as in `advanced-transformation-setting`.
@jongyoul please help reviewing this.
---