[GitHub] [incubator-tvm] kice edited a comment on issue #4529: [WINDOWS] Fix python exception Creation in Windows

[GitBox <gi...@apache.org>]

kice edited a comment on issue #4529: [WINDOWS] Fix python exception Creation in Windows
URL: https://github.com/apache/incubator-tvm/issues/4529#issuecomment-566379423
 
 
   Here return C error string
   
   https://github.com/apache/incubator-tvm/blob/10392854076a369bd8dfdf4d4044cad917285345/src/node/reflection.cc#L109-L110
   
   `[23:21:56] C:\src\tvm-win\src\node\reflection.cc:109: AttributeError: Schedule object has no attributed code_hash`
   
   https://github.com/apache/incubator-tvm/blob/10392854076a369bd8dfdf4d4044cad917285345/python/tvm/_ffi/base.py#L192-L198
   
   `_find_error_type` return `None` since after the split, `err_name` is `[23:`, thus `_valid_error_name` return `False`, which make `get_last_ffi_error` think it was not a py error and throw `<class 'tvm._ffi.base.TVMError'>`. 
   
   https://github.com/apache/incubator-tvm/blob/10392854076a369bd8dfdf4d4044cad917285345/python/tvm/_ffi/base.py#L175-L177
   
   I would suggest split the c error string into tokens by `:`, and check every token to see if it is a py error. 
   
   I think we should add a api to query which kind of error was happened, instead of checking the error string.
   
   But base on my analysis, this should also happen on Linux. Wired.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services