You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/11 07:26:12 UTC

[GitHub] [kafka] jlprat opened a new pull request #10669: KAFKA-12769: Backport of KAFKA-8562; SaslChannelBuilder - Avoid (reverse) DNS lookup while bui…

jlprat opened a new pull request #10669:
URL: https://github.com/apache/kafka/pull/10669


   …lding SslTransportLayer
   
   This is a cherry picked commit of https://github.com/apache/kafka/pull/10059 to branch 2.8
   
   Original commit message:
   This patch moves the `peerHost` helper defined in `SslChannelBuilder` into `SslFactor`. `SaslChannelBuilder` is then updated to use a new `createSslEngine` overload which relies on `peerHost` when building its `SslEngine`. The purpose is to avoid the reverse DNS in `getHostName`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jlprat commented on pull request #10669: KAFKA-12769: Backport too 2.8 of KAFKA-8562; SaslChannelBuilder - Avoid (reverse) DNS lookup while bui…

Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838708152


   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jlprat commented on pull request #10669: KAFKA-12769: Backport too 2.8 of KAFKA-8562; SaslChannelBuilder - Avoid (reverse) DNS lookup while bui…

Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838046575


   cc @vvcephei as mentioned on the mailing list, here there is a backport to 2.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jlprat closed pull request #10669: KAFKA-12769: Backport too 2.8 of KAFKA-8562; SaslChannelBuilder - Avoid (reverse) DNS lookup while bui…

Posted by GitBox <gi...@apache.org>.
jlprat closed pull request #10669:
URL: https://github.com/apache/kafka/pull/10669


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jlprat commented on pull request #10669: KAFKA-12769: Backport too 2.8 of KAFKA-8562; SaslChannelBuilder - Avoid (reverse) DNS lookup while bui…

Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838186948


   Test failure was:
   `Build / JDK 8 and Scala 2.12 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()`
   This flaky test is already fixed (https://issues.apache.org/jira/browse/KAFKA-12384) but only on `trunk` not on the `2.8` branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] omkreddy commented on pull request #10669: KAFKA-12769: Backport too 2.8 of KAFKA-8562; SaslChannelBuilder - Avoid (reverse) DNS lookup while bui…

Posted by GitBox <gi...@apache.org>.
omkreddy commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838656757


   @jlprat Thanks for PR. I will directly push the original commit to 2.8 and 2.7 branches. We can close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org