You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/24 07:12:49 UTC

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #745: Fixing login, session expired and blacklisted api requests

davidjumani opened a new pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745


   Fixes https://github.com/apache/cloudstack-primate/issues/740
   
   1. Notifies the user that the api could not be found or is not available
   2. Prevents logout if api not found or blacklisted
   2. Logs out wihtout refreshing the page
   
   ![Screenshot from 2020-09-24 12-41-00](https://user-images.githubusercontent.com/8244774/94112594-4a4d0380-fe63-11ea-8064-bddea87b2734.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698162197


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698179199


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698162597






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698908753


   ok , 2 extra tests done:
   <img width="1152" alt="Screenshot 2020-09-25 at 14 39 28" src="https://user-images.githubusercontent.com/2486961/94268822-024edf00-ff3e-11ea-8b9b-c3d68b23503e.png">
   
   and 
   
   <img width="944" alt="Screenshot 2020-09-25 at 14 42 44" src="https://user-images.githubusercontent.com/2486961/94268841-0975ed00-ff3e-11ea-92b5-2f57a1836f71.png">
    merging based on that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698722574


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698162597


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698767877


   LGTM
   @DaanHoogland can you review/test this? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698823220






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698178811


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] DaanHoogland merged pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698178811






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698166877


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/745 (JID-3508)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698162197






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698183817


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/745 (JID-3510)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698823220


   did a quick test on the pr link and got (cc @davidjumani )
   
   <img width="927" alt="image" src="https://user-images.githubusercontent.com/2486961/94250023-f7398600-ff20-11ea-940c-27a3982e1447.png">
   
   I'll have do extensive editting of roles while being logged on to test this, so postponing...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698725520


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/745 (JID-3517)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] DaanHoogland merged pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #745:
URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698722737


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org