You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/03 16:27:13 UTC
[GitHub] [cordova-ios] NiklasMerz opened a new pull request #820: Only set
bundleid to main app target
NiklasMerz opened a new pull request #820: Only set bundleid to main app target
URL: https://github.com/apache/cordova-ios/pull/820
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Closes #538
Apps with multiple targets get their bundleids in those targets not overwritten anymore
### Description
<!-- Describe your changes in detail -->
Requires two changes in the xcode package https://github.com/apache/cordova-node-xcode/pull/106 and
https://github.com/apache/cordova-node-xcode/pull/79
### Testing
<!-- Please describe in detail how you tested your changes. -->
Can be tested with an app with multiple targets with this branch https://github.com/GEDYSIntraWare/cordova-ios/tree/targetfixed
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] NiklasMerz merged pull request #820: Only set
bundleid to main app target
Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #820: Only set bundleid to main app target
URL: https://github.com/apache/cordova-ios/pull/820
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org