[GitHub] [incubator-devlake] klesh commented on a diff in pull request #3793: feat: implement DataSourcePipelinePlanV200 for gitlab

[GitBox <gi...@apache.org>]

klesh commented on code in PR #3793:
URL: https://github.com/apache/incubator-devlake/pull/3793#discussion_r1030364377


##########
plugins/gitlab/impl/impl.go:
##########
@@ -48,6 +57,64 @@ func (plugin Gitlab) Init(config *viper.Viper, logger core.Logger, db *gorm.DB)
 	return nil
 }
 
+func (plugin Gitlab) MakeDataSourcePipelinePlanV200(connectionId uint64, scopes []*core.BlueprintScopeV200) (pp core.PipelinePlan, sc []core.Scope, err errors.Error) {
+	pp = make(core.PipelinePlan, 0, 1)
+	sc = make([]core.Scope, 0, 3*len(scopes))
+	err = nil
+
+	// defer for NewDomainIdGenerator panic

Review Comment:
   Why NewDomainIdGenerator would panic?



##########
plugins/gitlab/impl/impl.go:
##########
@@ -48,6 +57,64 @@ func (plugin Gitlab) Init(config *viper.Viper, logger core.Logger, db *gorm.DB)
 	return nil
 }
 
+func (plugin Gitlab) MakeDataSourcePipelinePlanV200(connectionId uint64, scopes []*core.BlueprintScopeV200) (pp core.PipelinePlan, sc []core.Scope, err errors.Error) {

Review Comment:
   Please move the implementation to `api/blueprint_v200.go`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org