[kudu-CR] block manager: various changes to disk space reservation checking

["Mike Percy (Code Review)" <ge...@cloudera.org>]

Mike Percy has posted comments on this change.

Change subject: block_manager: various changes to disk space reservation checking
......................................................................


Patch Set 4: Code-Review+1

(4 comments)

Nice work, just a couple questions / comments

http://gerrit.cloudera.org:8080/#/c/4831/4/src/kudu/fs/block_manager-test.cc
File src/kudu/fs/block_manager-test.cc:

Line 933:   ASSERT_EQ(1, bm_->available_containers_by_data_dir_.begin()->second.size());
mind adding quick comment about what this is asserting on?


http://gerrit.cloudera.org:8080/#/c/4831/4/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:

Line 55: DEFINE_int64(fs_data_dirs_reserved_bytes, 0,
We'll have to doc this as breaking config backcompat but I think it is reasonable considering the semantics are broader now


Line 67: METRIC_DEFINE_gauge_uint64(server, data_dirs_full,
We should probably also provide a gauge metric for number of configured data dirs in total.


http://gerrit.cloudera.org:8080/#/c/4831/4/src/kudu/util/env_util.cc
File src/kudu/util/env_util.cc:

Line 136:   if (bytes_free - requested_bytes <= reserved_bytes) {
Why make this change? Semantically it seems off by one.


-- 
To view, visit http://gerrit.cloudera.org:8080/4831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2bb710a246ef09890554d1d6ff6da528145a6e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes