You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/02 03:19:33 UTC
[GitHub] [flink] jrthe42 commented on a change in pull request #11571:
[FLINK-16710][runtime] Log Upload blocks Main Thread in TaskExecutor
jrthe42 commented on a change in pull request #11571: [FLINK-16710][runtime] Log Upload blocks Main Thread in TaskExecutor
URL: https://github.com/apache/flink/pull/11571#discussion_r402029711
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -290,6 +295,8 @@ public TaskExecutor(
final ResourceID resourceId = taskExecutorServices.getUnresolvedTaskManagerLocation().getResourceID();
this.jobManagerHeartbeatManager = createJobManagerHeartbeatManager(heartbeatServices, resourceId);
this.resourceManagerHeartbeatManager = createResourceManagerHeartbeatManager(heartbeatServices, resourceId);
+
+ this.ioExecutor = Executors.newSingleThreadExecutor(new ExecutorThreadFactory("taskexecutor-io"));
Review comment:
Hi @GJL, I agree with your proposal. Moving this `ioExecutor` to `TaskManagerServices` will make code configurable and clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services