You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/03/21 12:48:53 UTC

[I] Add Helm chart CI validation [iggy]

hubcio opened a new issue, #3007:
URL: https://github.com/apache/iggy/issues/3007

   The chart at `helm/charts/iggy/` has zero CI coverage. The `helm` PR scope exists but no tests run.
   
   Add a `helm` component to the existing change-detection + test pipeline. 2 files, ~50 lines.
   
   `components.yml` - add helm component with `paths: ["helm/**"]`, `tasks: ["validate"]`. No `depends_on` (chart is independent of Rust build). Routes through existing `other_matrix` - no changes to `_detect.yml` or `pre-merge.yml`.
   
   `_test.yml` - add inline step (same pattern as `web-ui`/`ci-workflows`) with:
   - Pinned Helm install with SHA256 checksum (matching `yq` pattern in `_detect.yml`)
   - `helm lint --strict`
   - 6 `helm template` invocations covering all 10 templates and conditional branches:
     - default values (Deployment x2, Service x2, ServiceAccount, Secret)
     - all features enabled (+PVC, HPA, Ingress x2, ServiceMonitor)
     - legacy K8s 1.18 via `--kube-version` (Ingress v1beta1, HPA v2beta2 branches)
     - server only (`ui.enabled=false`)
     - UI only (`server.enabled=false`)
     - existing secret (`existingSecret.name` path vs `createSecret`)
   
   CI cost: 1 job, ~40s, runs only when `helm/**` changes.
   
   Future follow-ups (not this PR):
   - kubeconform schema validation
   - `values.schema.json`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add Helm chart CI validation [iggy]

Posted by "avirajkhare00 (via GitHub)" <gi...@apache.org>.
avirajkhare00 commented on issue #3007:
URL: https://github.com/apache/iggy/issues/3007#issuecomment-4111268839

   Thanks. Why not, how should we go about it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add Helm chart CI validation [iggy]

Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio closed issue #3007: Add Helm chart CI validation
URL: https://github.com/apache/iggy/issues/3007


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add Helm chart CI validation [iggy]

Posted by "avirajkhare00 (via GitHub)" <gi...@apache.org>.
avirajkhare00 commented on issue #3007:
URL: https://github.com/apache/iggy/issues/3007#issuecomment-4103280057

   Please assign it to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add Helm chart CI validation [iggy]

Posted by "avirajkhare00 (via GitHub)" <gi...@apache.org>.
avirajkhare00 commented on issue #3007:
URL: https://github.com/apache/iggy/issues/3007#issuecomment-4115143345

   Follow-up on the implementation in #3019: I updated the runtime-validation approach from the earlier port-forward smoke test to an ingress-based smoke test.
   
   Current approach:
   - keep `helm/validate` for the fast render-level coverage: pinned Helm install, `helm lint --strict`, the 6 requested `helm template` scenarios, deterministic legacy API assertions, and explicit chart/image version assertions
   - add a separate `helm/smoke` task for runtime coverage
   - `helm/smoke` now creates a `kind` cluster, installs pinned `ingress-nginx`, installs the chart with both `server.ingress` and `ui.ingress` enabled, and probes the two components through ingress hosts instead of using `kubectl port-forward`
   - the smoke checks are `GET /ping` for the server ingress path and `GET /healthz` for the UI ingress path
   - the UI image tag is pinned from `web/package.json` during the smoke install so the job is not coupled to the rolling `:edge` tag
   - on failure, the workflow collects namespace resources, ingresses, controller logs, pod descriptions, and kind logs
   
   Reason for the change: validating through ingress gives real coverage for the chart path we actually expose and exercises both components together, instead of only proving that the backing services were reachable with local port-forwards.
   
   The latest upstream pre-merge run for this approach passed: `23471288322`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add Helm chart CI validation [iggy]

Posted by "jackiecloudsec (via GitHub)" <gi...@apache.org>.
jackiecloudsec commented on issue #3007:
URL: https://github.com/apache/iggy/issues/3007#issuecomment-4111254471

   Would you like help @avirajkhare00
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add Helm chart CI validation [iggy]

Posted by "avirajkhare00 (via GitHub)" <gi...@apache.org>.
avirajkhare00 commented on issue #3007:
URL: https://github.com/apache/iggy/issues/3007#issuecomment-4115338637

   Follow-up from reviewing #3019: the hardcoding is concentrated in `.github/workflows/_test.yml`, but it is not all the same kind of hardcoding.
   
   A few values are CI-owned and are reasonable to keep inline: pinned tool versions/checksums, kind cluster shape, ingress-nginx install, smoke-test hosts, and ingress class. Those describe the CI environment, not the chart.
   
   The part that looks over-hardcoded is where the workflow repeats chart-owned values that already exist under `helm/charts/iggy/`, for example:
   - `helm/charts/iggy/Chart.yaml`: chart `version` and `appVersion`
   - `helm/charts/iggy/values.yaml`: `server.image.tag` and `ui.image.tag` defaults
   
   That makes `_test.yml` a second source of truth and means ordinary chart/version bumps need matching CI edits.
   
   I think the cleaner split is:
   - keep CI/runtime-specific values inline in `_test.yml`
   - move chart-specific render fixtures into the `helm/charts/iggy/` tree, or derive them directly from chart files, so the Helm directory stays the owner of chart data
   
   Issue #3007 explicitly asked for an inline step plus the 6 render scenarios, so some workflow verbosity is expected. The reusable part is the chart data, not the whole smoke-test setup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add Helm chart CI validation [iggy]

Posted by "jackiecloudsec (via GitHub)" <gi...@apache.org>.
jackiecloudsec commented on issue #3007:
URL: https://github.com/apache/iggy/issues/3007#issuecomment-4113397070

   Proposed solution:
   
   - First add this code block to .github/config/components.yml to meet the req to validate any changes made “helm/**"
   
   ```
   helm:
     paths:
       - "helm/**"
     tasks:
       - validate
   ```
   
   - Next adding this block to .github/workflows/_test.yml which grabs and uses the 4.1.3 AMD64 image of helm and then runs the verify job. 
   **Do we want arm64?**
   
   ```
   # - name: Install Helm (pinned)
           if: inputs.component == 'helm' && inputs.task == 'validate'
           run: |
             HELM_VERSION="v4.1.3"
             HELM_CHECKSUM="02ce9722d541238f81459938b84cf47df2fdf1187493b4bfb2346754d82a4700"
             wget -qO /tmp/helm.tar.gz "https://get.helm.sh/helm-${HELM_VERSION}-linux-amd64.tar.gz"
             echo "${HELM_CHECKSUM}  /tmp/helm.tar.gz" | sha256sum -c - || exit 1
             tar -zxvf /tmp/helm.tar.gz -C /tmp linux-amd64/helm
             chmod +x /tmp/linux-amd64/helm
             sudo mv /tmp/linux-amd64/helm /usr/local/bin/helm
    
         - name: Validate Helm chart
           if: inputs.component == 'helm' && inputs.task == 'validate'
           run: |
             set -euo pipefail
             C=helm/charts/iggy
   
             helm lint --strict "$C"
    
             # 1 — Defaults (Deployment x2, Service x2, ServiceAccount, Secret)
             helm template iggy "$C"
    
             # 2 — All features (+PVC, HPA, Ingress x2, ServiceMonitor)
             helm template iggy "$C" \
               --set server.persistence.enabled=true \
               --set autoscaling.enabled=true \
               --set autoscaling.targetCPUUtilizationPercentage=80 \
               --set server.ingress.enabled=true \
               --set ui.ingress.enabled=true \
               --set server.serviceMonitor.enabled=true
    
             # 3 — Legacy K8s 1.18 (Ingress v1beta1, HPA v2beta2)
             helm template iggy "$C" \
               --kube-version 1.18.0 \
               --api-versions networking.k8s.io/v1beta1 \
               --api-versions autoscaling/v2beta2 \
               --set autoscaling.enabled=true \
               --set autoscaling.targetCPUUtilizationPercentage=80 \
               --set server.ingress.enabled=true \
               --set ui.ingress.enabled=true
    
             # 4 — Server only
             helm template iggy "$C" --set ui.enabled=false
    
             # 5 — UI only
             helm template iggy "$C" --set server.enabled=false
    
             # 6 — Existing secret (skip createSecret)
             helm template iggy "$C" \
               --set server.users.root.createSecret=false \
               --set server.users.root.existingSecret.name=supersecret
    ```
   
   I had something a little less verbose but I think this would cover what is needed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add Helm chart CI validation [iggy]

Posted by "avirajkhare00 (via GitHub)" <gi...@apache.org>.
avirajkhare00 commented on issue #3007:
URL: https://github.com/apache/iggy/issues/3007#issuecomment-4114978311

   Implemented in #3019.
   
   Final scope:
   - added the `helm` component in `.github/config/components.yml` so `helm/**` changes route into the existing `other_matrix` with `validate`
   - added pinned Helm install, `helm lint --strict`, and the 6 requested `helm template` scenarios in `.github/workflows/_test.yml`
   - kept this in the existing CI path; no `_detect.yml` or `pre-merge.yml` changes were needed
   
   One adjustment from the original 2-file sketch: to make the legacy Kubernetes 1.18 case real, I also updated `helm/charts/iggy/templates/ingress.yaml` and `helm/charts/iggy/templates/hpa.yaml`. With the previous chart logic, `--kube-version 1.18.0` alone did not deterministically render the legacy API branches under Helm capabilities, so CI could pass without actually exercising `networking.k8s.io/v1beta1` and `autoscaling/v2beta2`. The templates now select those APIs from `KubeVersion`, and the workflow asserts that the legacy render produced them.
   
   Validation status:
   - local Helm validation passed for the full 6-scenario matrix
   - `Other • helm/validate / run` is passing on the upstream PR as well
   
   I followed the command-in-CI approach discussed here and did not add a separate `kind` smoke test in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org