You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/07 23:36:55 UTC
[GitHub] [superset] diegomedina248 opened a new pull request, #19605: fix: Query execution time is displayed as invalid date
diegomedina248 opened a new pull request, #19605:
URL: https://github.com/apache/superset/pull/19605
### SUMMARY
The Time column in the Query History is being displayed as an Invalid date.
The reason being the underlying data type is numeric with precision, to get sub-second precision.
That means the returned json value is a string (to keep the precision) and in turn, it fails the conversion to a moment object.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1728" alt="Screen Shot 2022-04-07 at 20 23 25" src="https://user-images.githubusercontent.com/17252075/162336157-b1eae912-8882-44d9-858c-dd9e79fbf88a.png">
After:
<img width="1710" alt="new" src="https://user-images.githubusercontent.com/17252075/162336108-33aeaf4a-6f8f-469d-a39d-115894339ec8.png">
### TESTING INSTRUCTIONS
1. Go to SQL lab -> SQL Editor
2. Run any query
3. Go to SQL lab -> Query History
Ensure the time column is displaying the proper start time.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19605:
URL: https://github.com/apache/superset/pull/19605#issuecomment-1093007212
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19605:
URL: https://github.com/apache/superset/pull/19605#issuecomment-1092311677
@yousoph Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19605:
URL: https://github.com/apache/superset/pull/19605#issuecomment-1092311671
@yousoph Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #19605:
URL: https://github.com/apache/superset/pull/19605#issuecomment-1115141097
π·οΈ preset:2022.17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #19605:
URL: https://github.com/apache/superset/pull/19605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19605:
URL: https://github.com/apache/superset/pull/19605#issuecomment-1092314377
@yousoph Ephemeral environment spinning up at http://18.236.68.118:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codemaster08240328 commented on a diff in pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
codemaster08240328 commented on code in PR #19605:
URL: https://github.com/apache/superset/pull/19605#discussion_r848310362
##########
superset-frontend/src/views/CRUD/data/query/QueryList.tsx:
##########
@@ -181,12 +181,9 @@ function QueryList({ addDangerToast, addSuccessToast }: QueryListProps) {
accessor: QueryObjectColumns.start_time,
Header: t('Time'),
size: 'xl',
- Cell: ({
- row: {
- original: { start_time, end_time },
- },
- }: any) => {
- const startMoment = moment.utc(start_time).local();
+ Cell: ({ row: { original } }: any) => {
+ const startTime = parseFloat(original.start_time);
Review Comment:
@diegomedina248 , I absolutely believe it works pretty well, but for just one confirmation.
Can you please check if the date field in text report to email is formatted correctly?
(Reason: It seems like by saving date in query result as a string, we resolved this issue in text report.)
Step:
1. Create a table chart including dates.
2. Create a report sending this chart as a report to email.
3. Date should be formatted as it appears in the chart.
The result we don't expect:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a diff in pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on code in PR #19605:
URL: https://github.com/apache/superset/pull/19605#discussion_r848816969
##########
superset-frontend/src/views/CRUD/data/query/QueryList.tsx:
##########
@@ -181,12 +181,9 @@ function QueryList({ addDangerToast, addSuccessToast }: QueryListProps) {
accessor: QueryObjectColumns.start_time,
Header: t('Time'),
size: 'xl',
- Cell: ({
- row: {
- original: { start_time, end_time },
- },
- }: any) => {
- const startMoment = moment.utc(start_time).local();
+ Cell: ({ row: { original } }: any) => {
+ const startTime = parseFloat(original.start_time);
Review Comment:
Yeah, as far as I can tell with my tests, this change does not affect that.
The code changes only affect the JSON response in the API, so we should be good there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #19605: fix: Query execution time is displayed as invalid date
URL: https://github.com/apache/superset/pull/19605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #19605:
URL: https://github.com/apache/superset/pull/19605#issuecomment-1092313289
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a diff in pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on code in PR #19605:
URL: https://github.com/apache/superset/pull/19605#discussion_r847881855
##########
superset-frontend/src/views/CRUD/data/query/QueryList.tsx:
##########
@@ -181,12 +181,9 @@ function QueryList({ addDangerToast, addSuccessToast }: QueryListProps) {
accessor: QueryObjectColumns.start_time,
Header: t('Time'),
size: 'xl',
- Cell: ({
- row: {
- original: { start_time, end_time },
- },
- }: any) => {
- const startMoment = moment.utc(start_time).local();
+ Cell: ({ row: { original } }: any) => {
+ const startTime = parseFloat(original.start_time);
Review Comment:
Agreed, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19605:
URL: https://github.com/apache/superset/pull/19605#discussion_r847007434
##########
superset-frontend/src/views/CRUD/data/query/QueryList.tsx:
##########
@@ -181,12 +181,9 @@ function QueryList({ addDangerToast, addSuccessToast }: QueryListProps) {
accessor: QueryObjectColumns.start_time,
Header: t('Time'),
size: 'xl',
- Cell: ({
- row: {
- original: { start_time, end_time },
- },
- }: any) => {
- const startMoment = moment.utc(start_time).local();
+ Cell: ({ row: { original } }: any) => {
+ const startTime = parseFloat(original.start_time);
Review Comment:
This issue seems that we should change the `start_time` and `end_time` from the server side to the float.
Those columns in `Query` was numberic. We should fix the response type.
https://github.com/apache/superset/blob/a6bf041eddcde0247461f35c806414df00ef105e/superset/models/sql_lab.py#L97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #19605:
URL: https://github.com/apache/superset/pull/19605#issuecomment-1092311377
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19605:
URL: https://github.com/apache/superset/pull/19605#issuecomment-1092322730
# [Codecov](https://codecov.io/gh/apache/superset/pull/19605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19605](https://codecov.io/gh/apache/superset/pull/19605?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (194368b) into [master](https://codecov.io/gh/apache/superset/commit/f91f83d011b4c83576f5fff76d502f5616f2972d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f91f83d) will **increase** coverage by `0.02%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #19605 +/- ##
==========================================
+ Coverage 66.65% 66.68% +0.02%
==========================================
Files 1680 1681 +1
Lines 64292 64304 +12
Branches 6564 6565 +1
==========================================
+ Hits 42854 42879 +25
+ Misses 19736 19730 -6
+ Partials 1702 1695 -7
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `51.51% <66.66%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...t-frontend/src/views/CRUD/data/query/QueryList.tsx](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeUxpc3QudHN4) | `53.84% <66.66%> (+0.72%)` | :arrow_up: |
| [...ntend/packages/superset-ui-core/src/color/utils.ts](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvdXRpbHMudHM=) | `97.14% <0.00%> (-2.86%)` | :arrow_down: |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ΓΈ)` | |
| [...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXNhbmtleS9zcmMvUmVhY3RTYW5rZXkuanN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...s/legacy-plugin-chart-horizon/src/HorizonChart.jsx](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhvcml6b24vc3JjL0hvcml6b25DaGFydC5qc3g=) | `0.00% <0.00%> (ΓΈ)` | |
| [...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhaXJlZC10LXRlc3Qvc3JjL1BhaXJlZFRUZXN0LmpzeA==) | `0.00% <0.00%> (ΓΈ)` | |
| [...rt-parallel-coordinates/src/ParallelCoordinates.js](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcmFsbGVsLWNvb3JkaW5hdGVzL3NyYy9QYXJhbGxlbENvb3JkaW5hdGVzLmpz) | `0.00% <0.00%> (ΓΈ)` | |
| [...allel-coordinates/src/ReactParallelCoordinates.jsx](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcmFsbGVsLWNvb3JkaW5hdGVzL3NyYy9SZWFjdFBhcmFsbGVsQ29vcmRpbmF0ZXMuanN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...gacy-plugin-chart-partition/src/ReactPartition.jsx](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUmVhY3RQYXJ0aXRpb24uanN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `48.85% <0.00%> (+1.19%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/superset/pull/19605/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19605?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19605?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f91f83d...194368b](https://codecov.io/gh/apache/superset/pull/19605?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19605: fix: Query execution time is displayed as invalid date
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #19605:
URL: https://github.com/apache/superset/pull/19605#discussion_r847007434
##########
superset-frontend/src/views/CRUD/data/query/QueryList.tsx:
##########
@@ -181,12 +181,9 @@ function QueryList({ addDangerToast, addSuccessToast }: QueryListProps) {
accessor: QueryObjectColumns.start_time,
Header: t('Time'),
size: 'xl',
- Cell: ({
- row: {
- original: { start_time, end_time },
- },
- }: any) => {
- const startMoment = moment.utc(start_time).local();
+ Cell: ({ row: { original } }: any) => {
+ const startTime = parseFloat(original.start_time);
Review Comment:
Why do we parse the string to a float, instead of web server response a float value directly? This issue seems that we should change the `start_time` and `end_time` from the server side to the float.
Those columns in `Query` was numberic. We should fix the response type.
https://github.com/apache/superset/blob/a6bf041eddcde0247461f35c806414df00ef105e/superset/models/sql_lab.py#L97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org