You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/05/16 03:51:24 UTC
[GitHub] [incubator-mxnet] connorgoggins opened a new pull request #18340: [Website 2.0] Artifact URL Adjustment
connorgoggins opened a new pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340
## Description ##
This PR officially transfers ownership of code version control and compressed artifact storage for the static artifacts for the MXNet website from Connor Goggins to the MXNet Website team. The new S3 bucket (owned by the AWS account for ai-mxnet-engineering@amazon.com) gives the team the ability to update the artifacts as needed. The specific purpose of this PR is to change the artifact download link in the Jenkinsfile to point to the compressed artifacts in the new S3 bucket instead of the previous bucket.
These changes will increase the accessibility of the MXNet Website 2.0 static artifacts to the team in case of future modifications. For additional details and supporting documentation, please read [this doc](https://quip-amazon.com/4i2GAb8huyKC/MXNet-Website-20-Static-Artifact-Mangement).
## Checklist ##
### Essentials ###
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] Code is well-documented
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- M docs/static_site/Makefile
## Comments ##
These changes have been tested with a complete website build on Jenkins dev and local hosting. All functionality remains the same.
@sandeep-krishnamurthy @aaronmarkham @ys2843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #18340: [Website 2.0] Artifact URL Adjustment
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340#discussion_r426552946
##########
File path: docs/static_site/Makefile
##########
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
- wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
+ wget https://mxnet-website-static-artifacts.s3.us-east-2.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
Review comment:
It gets autogenerated when unpacking the zip, since the archive was created on a Mac.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] aaronmarkham commented on a change in pull request #18340: [Website 2.0] Artifact URL Adjustment
Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on a change in pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340#discussion_r426155329
##########
File path: docs/static_site/Makefile
##########
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
- wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
+ wget https://mxnet-website-static-artifacts.s3.us-east-2.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
Review comment:
What's the macosx folder for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on pull request #18340: [Website 2.0] Artifact URL Adjustment
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340#issuecomment-629583487
@mxnet-label-bot add [Website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #18340: [Website 2.0] Artifact URL Adjustment
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340#discussion_r426552946
##########
File path: docs/static_site/Makefile
##########
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
- wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
+ wget https://mxnet-website-static-artifacts.s3.us-east-2.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
Review comment:
When ZIP artifacts are compiled on a Mac (as the current artifact is), the `__MACOSX` folder is autogenerated when they are extracted. If future versions of the artifact are compiled using a different OS, this won't cause any problems since the `rm -rf` command will pass even if the specified folder doesn't exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18340: [Website 2.0] Artifact URL Adjustment
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340#issuecomment-629583305
Hey @connorgoggins , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, unix-gpu, sanity, centos-cpu, centos-gpu, unix-cpu, website, windows-gpu, clang, miscellaneous, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] aaronmarkham merged pull request #18340: [Website 2.0] Artifact URL Adjustment
Posted by GitBox <gi...@apache.org>.
aaronmarkham merged pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on pull request #18340: [Website 2.0] Artifact URL Adjustment
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on pull request #18340:
URL: https://github.com/apache/incubator-mxnet/pull/18340#issuecomment-629583448
@mxnet-label-bot add [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org