Re: [PR] [SPARK-34591][MLLIB][WIP] Add decision tree pruning as a parameter [spark]

["ramou2023 (via GitHub)" <gi...@apache.org>]

ramou2023 commented on PR #32813:
URL: https://github.com/apache/spark/pull/32813#issuecomment-1744746230

   > @asolimando
   > 
   > > As a closing remark, I understand that this have caused some issues and frustrations to some people including yourself, but sometimes trying to make things better (maybe by volunteering in our spare time, like it was the case for me for this PR), we can cause other issues, which can in turn be tackled and hopefully solved, that's the beauty of OSS.
   > 
   > We definitely appreciate the all the time volunteers like yourself have spent improving the code. We wouldn't be able to do our work without it :)
   > 
   > My comments above were intended to convey the fact that I personally know significant numbers of people who have encountered this in one form or another and therefore this isn't a rare side effect - it's actually a common one.
   > 
   > There are workarounds too (although not ideal):
   > 
   > * Instead of using DecisionTreeClassifier, use GBTClassifier with numiter=1 and settings which make it functionally identical to a decision tree
   > * Instead of using RandomForestClassifier, use GBTClassifier (although this isn't helpful if you actually want a RandomForestClassifier for some reason)
   > 
   > Thankfully it's an easily addressable issue, notwithstanding the performance hit.
   
   Hello,
   Thank for your suggestion to use  GBTclassifier. But i have  a problem with impurity parameter, it's not possible to use gini index. 
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org