You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/04/14 00:25:10 UTC
[GitHub] [couchdb] tonysun83 opened a new pull request #3506: Port prometheus 3.x
tonysun83 opened a new pull request #3506:
URL: https://github.com/apache/couchdb/pull/3506
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
This is a port of https://github.com/apache/couchdb/pull/3416.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] tonysun83 merged pull request #3506: Port prometheus 3.x
Posted by GitBox <gi...@apache.org>.
tonysun83 merged pull request #3506:
URL: https://github.com/apache/couchdb/pull/3506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #3506: Port prometheus 3.x
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3506:
URL: https://github.com/apache/couchdb/pull/3506#issuecomment-854794608
@tonysun83 Thanks for the work here. Looking generally good, left my comments over there. If you can address the remaining documentation gaps this is +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #3506: Port prometheus 3.x
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3506:
URL: https://github.com/apache/couchdb/pull/3506#issuecomment-852482541
@tonysun83
1. Is it enabled or disabled by default? Looks like enabled and bound to 127.0.0.1:17986 by default, is this accurate?
2. Is this disable-able at all?
3. Can you write some docs for this? I see no mention of this functionality anywhere in apache/couchdb-documentation. I can't really release this as a new exciting in feature in 3.2 without something in the docs.
Thanks,
Joan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] tonysun83 commented on pull request #3506: Port prometheus 3.x
Posted by GitBox <gi...@apache.org>.
tonysun83 commented on pull request #3506:
URL: https://github.com/apache/couchdb/pull/3506#issuecomment-852552554
@wohali
1) + 2) The additional port/mochiweb server is disabled by default, but the ability to return prometheus metrics via the traditional 5984 port is always on.
3) Ya I can write this up tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] tonysun83 edited a comment on pull request #3506: Port prometheus 3.x
Posted by GitBox <gi...@apache.org>.
tonysun83 edited a comment on pull request #3506:
URL: https://github.com/apache/couchdb/pull/3506#issuecomment-852552554
@wohali
1 + 2 The additional port/mochiweb server is disabled by default, but the ability to return prometheus metrics via the traditional 5984 port is always on.
3) Ya I can write this up tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] tonysun83 commented on pull request #3506: Port prometheus 3.x
Posted by GitBox <gi...@apache.org>.
tonysun83 commented on pull request #3506:
URL: https://github.com/apache/couchdb/pull/3506#issuecomment-853281146
@wohali I've added documentation PR here: https://github.com/apache/couchdb-documentation/pull/660 I need to clean some things up as the build is failing but let me know in terms of content if I'm missing anything you'd like me to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org