[GitHub] [flink] pltbkd commented on pull request #19464: [FLINK-27148][checkpoint] Skip snapshotting the coordinators state or the master state if the pending checkpoint has been disposed.

[GitBox <gi...@apache.org>]

pltbkd commented on PR #19464:
URL: https://github.com/apache/flink/pull/19464#issuecomment-1101145312

   > 1. hen we could remove actions related to `manuallyTriggeredScheduledExecutor`. For mock `OperatorCoordinatorContext`, I think we could simply add a callback to `abortTriggering` in `MockOperatorCheckpointCoordinatorContextBuilder`.
   
   Thanks for the suggestion! Although the behavior is still strictly bound to the current implementation, the code is much clearer. And an UT of the checkpoint coordinator is not responsible to validate the behavior of the operator coordinator, so a mock of the operator coordinator can be useful. I'll follow the suggestion and modify the PR soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org