You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "Myasuka (via GitHub)" <gi...@apache.org> on 2023/05/28 07:25:00 UTC

[GitHub] [incubator-paimon] Myasuka commented on a diff in pull request #940: [WIP] Support Async lookup for Paimon-flink

Myasuka commented on code in PR #940:
URL: https://github.com/apache/incubator-paimon/pull/940#discussion_r1208399678


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/lookup/FileStoreLookupFunction.java:
##########
@@ -120,10 +139,20 @@ public FileStoreLookupFunction(
     }
 
     public void open(FunctionContext context) throws Exception {
-        String tmpDirectory = getTmpDirectory(context);
+        Options options = Options.fromMap(table.options());
+
+        this.lookupAsync = options.get(FlinkConnectorOptions.LOOKUP_ASYNC);
+        if (lookupAsync) {
+            this.lock = new ReentrantLock();
+            this.asyncThreadPool =
+                    Executors.newFixedThreadPool(
+                            ASYNC_THREAD_POOL_SIZE,

Review Comment:
   Got it, thanks for the reminder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org