You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/03 18:58:21 UTC

[GitHub] [superset] rajraousb opened a new issue #17914: [SIP] Proposal for controlling access to Dashboards

rajraousb opened a new issue #17914:
URL: https://github.com/apache/superset/issues/17914


   Motivation
   Conditions for showing Dashboards in the UI
   •	Dashboards for which the current user is the creator
   •	Dashboards for which the current user is part of "Co-owner" as defined in the Dashboard creation/edit
   •	Dashboards which are published
   There is no option available to share Dashboard with only Read Only capability
   Proposed Change
   This SIP aims to provide a new set of users called Viewers
   •	Provide capability to have Viewers field similar to Owners field	
   •	Viewers will be able to see the Dashboards in their account when they click on Dashboards panel	
   •	Viewers will have only Read-Only access (Co-owners have Read-Write access)
   New or Changed Public Interfaces
   •	Add a new table similar to "Dashboard Owners", called "Dashboard Viewers". These tables are internal Superset database tables.
   •	This table creation can be created in the "superset db upgrade" hook
   •	Add UI component called "Viewers", which will populate "Dashboard Viewers" table based on dashboard_id and user_id of viewers selected from UI
   •	Add handlers for Viewers in UI (e.g. label, description, composite combo box etc.)
   •	Modify Dashboard model to add Viewers as extra attribute of "Dashboard Viewers" type linking dashboard and user table
   •	We will be enhancing the capability that we implemented for Co-Owner where in we will automatically add access to the underlying charts associated withe Dashboard to the Viewers
   
   <See Document>
   
   [SIP Viewers.docx](https://github.com/apache/superset/files/7803565/SIP.Viewers.docx)
   
   New dependencies
   New database called dashboard_viewers
   <See Document above>
   
   Migration Plan and Compatibility
   Create a db upgrade file
   <See Document Above>
   
   Rejected Alternatives
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb commented on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005153651


   Hi @amitmiran137 10408 is at role level.
   Generally, all users in a particular team will have same role(s). However within the same team, there might be a need to have e.g. user1 have Owner role, user2 as Co-Owner, user3 & user4 as just Viewers.
   Creating a role just for this purpose and assigning is an administrative overhead.
   Also, let's say we need to drop user4, this again needs a role change.
   
   An easier solution is to expand the same logic as in co-owners which I have described in the proposal. Users can easily add/remove other users from Viewers and/or Owners list.
   
   Also, it's easy to populate a particular user's dashboard with all dashboard for which they are Owners/Viewers.
   
   This will also help in https://github.com/apache/superset/issues/17913 where other users can be restricted access as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005166190


   we have tried doing a full blown attempt for a RBAC  to any object in superset that can later be expanded to support individual users but got held back due to some issues:
   https://github.com/apache/superset/pull/17057


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb commented on issue #17914: [SIP] Proposal for controlling access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1004378331


   ```
   r1@r1server:~/ss35/superset-0.35$ diff superset/views/core.py ../../orig/superset-0.35/superset/views/core.py
   247d246
   <       4. Those which the user has Viewer access
   289,294d287
   <         viewer_ids_query = (
   <             db.session.query(Dash.id)
   <             .join(Dash.viewers)
   <             .filter(User.id == User.get_user_id())
   <         )
   <
   298d290
   <                 Dash.id.in_(viewer_ids_query),
   485,486d476
   <
   500,501c490
   <         "owners",                                    
   <         "viewers",
   ---
   >         "owners",
   507,508d495
   <
   537,541d523
   <         "viewers": _("Viewers is a list of users who can view the dashboard."),
   <         "published": _(
   <             "Determines whether or not this dashboard is "
   <             "visible in the list of all dashboards"
   <         ),
   543d524
   550,551c531
   <         "owners": _("Owners"),
   <         "viewers": ("Viewers"),
   ---
   >         "owners": _("Owners"),
   
   
   ```
   
   ### New dependencies
   New database called dashboard_viewers
   ```
   r1@r1server:~/ss35/superset-0.35$ diff superset/models/core.py ../../orig/superset-0.35/superset/models/core.py
   411,420d410
   < dashboard_viewer = Table(
   <     "dashboard_viewer",
   <     metadata,
   <     Column("id", Integer, primary_key=True),
   <     Column("user_id", Integer, ForeignKey("ab_user.id")),
   <     Column("dashboard_id", Integer, ForeignKey("dashboards.id")),
   < )
   <
   <
   <
   435d424
   <     viewers =  relationship(security_manager.user_model, secondary=dashboard_viewer)
   ```
   ### Migration Plan and Compatibility
   ```
   """dashboard_viewers
   
   Revision ID: b922b18232ab
   Revises: 2f1d15e8a6af
   Create Date: 2021-09-30 05:29:03.108813
   
   """
   
   # revision identifiers, used by Alembic.
   revision = 'b922b18232ab'
   down_revision = '2f1d15e8a6af'
   
   from alembic import op
   import sqlalchemy as sa
   
   
   def upgrade():
       op.create_table(
           "dashboard_viewers",
           sa.Column("id", sa.Integer(), nullable=False),
           sa.Column("user_id", sa.Integer(), nullable=True),
           sa.Column("dashboard_id", sa.Integer(), nullable=True),
           sa.ForeignKeyConstraint(["dashboard_id"], ["dashboards.id"]),
           sa.ForeignKeyConstraint(["user_id"], ["ab_user.id"]),
           sa.PrimaryKeyConstraint("id"),
       )
   
   
   def downgrade():
       op.drop_table("dashboard_viewers")
   
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005146730


   Hey @rajraousb thank you for taking the time to pp LAN and design this.
   
   Would you mind taking a look in https://github.com/apache/superset/issues/10408
   And see if that proposal answer the requirements that you stated in this proposal
   
   If that is the case so go ahead and use it 
   
   If not let me know what do you think is still missing 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb commented on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1015625899


   @BinRoq 
   The code you pasted is from my proposal https://github.com/apache/superset/issues/17913 where we can use the Viewers feature to restrict access to Dashboards


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb edited a comment on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb edited a comment on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005170318


   That is good for future versions, Amit. Looking forward to that.
   
   However for all the older versions we can use a solution like this, eliminating need for feature flags or specific roles per dashboard and also easier migration & management etc.
   
   This solution can work in 0.3x, 1.x versions and potentially others too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 edited a comment on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
amitmiran137 edited a comment on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005166190


   we have tried doing a full blown solution for a RBAC  to any object in superset that can later be expanded to support individual users but got held back due to some issues:
   https://github.com/apache/superset/pull/17057


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 edited a comment on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
amitmiran137 edited a comment on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005160236


   In general I think we should address data access control in some kind of a 2.0 version and generify all access management into a unified solution
   
   Here in this comment is the proposal we have tried pushing for a while now.
   
   is address access both on a user/role levels with the exact same mechanisem
   https://github.com/apache/superset/issues/16557#issuecomment-911502003
   
   cc:
   @betodealmeida @villebro @dpgaspar 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005160236


   In general I think we should address data access control in some kind of a 2.0 version and generify all access management into a unified solution
   
   Here in this comment is the proposal we have tried pushing for a while now.
   
   https://github.com/apache/superset/issues/16557#issuecomment-911502003
   
   cc:
   @betodealmeida @villebro @dpgaspar 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb commented on issue #17914: [SIP] Proposal for controlling access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1004375338


   ![Picture1](https://user-images.githubusercontent.com/97055451/147982879-605febaf-36cc-4a45-a27f-b42a9cf0fa44.jpg)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1006053147


   But you are referring to a solution that needs development and will only be supportrd in new releases 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb edited a comment on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb edited a comment on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005153651


   Hi @amitmiran137 Thanks for the comment. 10408 is at role level.
   Generally, all users in a particular team will have same role(s). However within the same team, there might be a need to have e.g. user1 have Owner role, user2 as Co-Owner, user3 & user4 as just Viewers.
   Creating a role just for this purpose and assigning is an administrative overhead.
   Also, let's say we need to drop user4, this again needs a role change.
   
   An easier solution is to expand the same logic as in co-owners which I have described in the proposal. Users can easily add/remove other users from Viewers and/or Owners list.
   
   Also, it's easy to populate a particular user's dashboard with all dashboard for which they are Owners/Viewers.
   
   This will also help in https://github.com/apache/superset/issues/17913 where other users can be restricted access as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb commented on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005170318


   That is good for future versions, Amit. Looking forward to that.
   
   However for all the older versions we can use a solution like this, eliminating need for feature flags or specific roles per dashboard and also easier migration & management etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] BinRoq commented on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
BinRoq commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1011937745


       @has_access
       @expose("/dashboard/<dashboard_id>/")
       def dashboard(self, dashboard_id):
           """Server side rendering for a dashboard"""
   
           def check_owner_or_viewer(obj):
           #See if current user has either owner or viewer permission
   
               if not obj:
                   return False
   
               if g.user.is_anonymous:
                   return False
   
               roles = [r.name for r in get_user_roles()]
               if "Admin" in roles:
                   return True
   
               owners = []
               owners += obj.owners
   
               owners += obj.viewers
   
               owner_names = [o.username for o in owners if o]
   
   
               if g.user and hasattr(g.user, "username") and g.user.username in owner_names:
                   return True
   
   
   
               return False
   
   
           session = db.session()
           qry = session.query(models.Dashboard)
           if dashboard_id.isdigit():
               qry = qry.filter_by(id=int(dashboard_id))
           else:
               qry = qry.filter_by(slug=dashboard_id)
   
           dash = qry.one_or_none()
           if not dash:
               abort(404)
   
   
           if check_owner_or_viewer( dash ) == False:
               bootstrap_data = {
                   "user_id": g.user.get_id(),
   
                   "user_name": g.user.username,
                   "user.first_name": g.user.first_name,
                   "user.last_name": g.user.last_name,
   
                   "dashboard_id": dash.id,
                   "dashboard_title": dash.dashboard_title,
                   "error": "Need either Owner or Viewer privilege to view this dashboard",
               }
   
   
               flash(__("You have no permission to view this dashboard"), "danger")
   
               return json_success(json.dumps(bootstrap_data))
   
   
   
   
           datasources = set()
           for slc in dash.slices:
               datasource = slc.datasource
               if datasource:
                   datasources.add(datasource)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 edited a comment on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
amitmiran137 edited a comment on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005146730


   Hey @rajraousb thank you for taking the time to plan and design this.
   
   Would you mind taking a look in https://github.com/apache/superset/issues/10408
   And see if that proposal answer the requirements that you stated in this proposal
   
   If that is the case so go ahead and use it 
   
   If not let me know what do you think is still missing 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb edited a comment on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb edited a comment on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1015625899


   @BinRoq 
   The code you pasted is from my proposal https://github.com/apache/superset/issues/17913 where we can use the Viewers feature to restrict access to Dashboards
   Any comments/suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb edited a comment on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb edited a comment on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005153651


   Hi @amitmiran137 Thanks for the comment. 10408 is at role level.
   Generally, all users in a particular team will have same role(s). However within the same team, there might be a need to have e.g. user1 have Owner role, user2 as Co-Owner, user3 & user4 as just Viewers.
   Creating a role just for this purpose and assigning is an administrative overhead.
   Also, let's say we need to drop user4, this again needs a role change.
   Also, this fits in seamlessly with the Dashboard creation/editing framework where we define co-owners rather than a separate role creation task.
   
   An easier solution is to expand the same logic as in co-owners which I have described in the proposal. Users can easily add/remove other users from Viewers and/or Owners list.
   
   Also, it's easy to populate a particular user's dashboard with all **Dashboards** for which they are Owners/Viewers.
   
   This will also help in https://github.com/apache/superset/issues/17913 where other users can be restricted access as well.
   
   By providing granularity at user level, it is possible to define access to each dashboard for specific users (like the Owners list)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rajraousb edited a comment on issue #17914: [SIP] Proposal for controlling View Only access to Dashboards

Posted by GitBox <gi...@apache.org>.
rajraousb edited a comment on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1005153651


   Hi @amitmiran137 Thanks for the comment. 10408 is at role level.
   Generally, all users in a particular team will have same role(s). However within the same team, there might be a need to have e.g. user1 have Owner role, user2 as Co-Owner, user3 & user4 as just Viewers.
   Creating a role just for this purpose and assigning is an administrative overhead.
   Also, let's say we need to drop user4, this again needs a role change.
   Also, this fits in seamlessly with the Dashboard creation/editing framework where we define co-owners rather than a separate role creation task.
   
   An easier solution is to expand the same logic as in co-owners which I have described in the proposal. Users can easily add/remove other users from Viewers and/or Owners list.
   
   Also, it's easy to populate a particular user's dashboard with all dashboard for which they are Owners/Viewers.
   
   This will also help in https://github.com/apache/superset/issues/17913 where other users can be restricted access as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] betodealmeida commented on issue #17914: [SIP] Proposal for controlling access to Dashboards

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on issue #17914:
URL: https://github.com/apache/superset/issues/17914#issuecomment-1004351720


   @rajraousb do you mind formatting the post with Markdown headers, to make it easier to read? Also, instead of attaching a `.docx` file please include the text as Markdown directly in the description, since people might not have tools to open a proprietary Word document.
   
   Note that Superset supports dashboard-specific access roles (https://github.com/apache/superset/issues/10408) via the `DASHBOARD_RBAC` feature flag, which seem to cover at least some of the use cases you list here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org