[jira] [Commented] (BEAM-1050) PipelineResult.State is not set to FAILED when a streaming job fails

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709693#comment-15709693 ] 

ASF GitHub Bot commented on BEAM-1050:
--------------------------------------

Github user staslev closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1438


> PipelineResult.State is not set to FAILED when a streaming job fails
> --------------------------------------------------------------------
>
>                 Key: BEAM-1050
>                 URL: https://issues.apache.org/jira/browse/BEAM-1050
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>            Priority: Minor
>
> In case of failure, {{SteamingContext#awaitTerminationOrTimeout}} and {{SteamingContext#awaitTermination}} will both throw an exception, and so {{state = State.DONE}} will not be executed in the code block below. 
> In addition, it would probably make sense to set {{state = State.FAILED}} in cases where an exception takes place.
> {code:java}
> if (isStreamingPipeline()) {
>       // stop streaming context
>       if (timeout > 0) {
>         jssc.awaitTerminationOrTimeout(timeout);
>       } else {
>         jssc.awaitTermination();
>       }
>       // stop streaming context gracefully, so checkpointing (and other computations) get to
>       // finish before shutdown.
>       jssc.stop(false, gracefully);
>     }
>     state = State.DONE;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)