You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/22 09:04:49 UTC

[GitHub] [spark] pengbo opened a new pull request #24436: [SPARK-27539][SQL] Inaccurate aggregate outputRows estimation with column contains null value

pengbo opened a new pull request #24436: [SPARK-27539][SQL] Inaccurate aggregate outputRows estimation with column contains null value
URL: https://github.com/apache/spark/pull/24436
 
 
   ## What changes were proposed in this pull request?
   This PR is follow up of https://github.com/apache/spark/pull/24286. As @gatorsmile pointed out that column with null value is inaccurate as well.
   
   ```
   > select key from test;
   2
   NULL
   1
   spark-sql> desc extended test key;
   col_name key
   data_type int
   comment NULL
   min 1
   max 2
   num_nulls 1
   distinct_count 2
   ```
   
   The distinct count should be distinct_count + 1 when the column contains null value.
   ## How was this patch tested?
   
   Existing tests & new UT added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org