You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/05 00:45:28 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #3895: Fix
the RecordReader to pick incoming time column
codecov-io edited a comment on issue #3895: Fix the RecordReader to pick incoming time column
URL: https://github.com/apache/incubator-pinot/pull/3895#issuecomment-468485205
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=h1) Report
> Merging [#3895](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/ce551ebfe15e11e6fb008fc59661d388e2a388a0?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `82.3%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3895 +/- ##
============================================
- Coverage 67.23% 67.21% -0.03%
Complexity 4 4
============================================
Files 1032 1032
Lines 50897 50884 -13
Branches 7109 7108 -1
============================================
- Hits 34220 34200 -20
- Misses 14339 14344 +5
- Partials 2338 2340 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/pinot/core/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0F2cm9VdGlscy5qYXZh) | `41.48% <ø> (-11.41%)` | `0 <0> (ø)` | |
| [...e/pinot/core/data/readers/RecordReaderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyRmFjdG9yeS5qYXZh) | `42.85% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/core/data/readers/JSONRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvSlNPTlJlY29yZFJlYWRlci5qYXZh) | `90% <100%> (-0.91%)` | `0 <0> (ø)` | |
| [...time/impl/kafka/AvroRecordToPinotRowGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2thZmthL0F2cm9SZWNvcmRUb1Bpbm90Um93R2VuZXJhdG9yLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/core/data/readers/AvroRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQXZyb1JlY29yZFJlYWRlci5qYXZh) | `85.1% <100%> (+7.05%)` | `0 <0> (ø)` | :arrow_down: |
| [...che/pinot/core/data/readers/RecordReaderUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyVXRpbHMuamF2YQ==) | `75.3% <77.94%> (+6.07%)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/core/data/readers/ThriftRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvVGhyaWZ0UmVjb3JkUmVhZGVyLmphdmE=) | `83.67% <83.33%> (+2.13%)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/core/data/readers/CSVRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQ1NWUmVjb3JkUmVhZGVyLmphdmE=) | `71.15% <88.88%> (+2.52%)` | `0 <0> (ø)` | :arrow_down: |
| [...startree/executor/StarTreeAggregationExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9leGVjdXRvci9TdGFyVHJlZUFnZ3JlZ2F0aW9uRXhlY3V0b3IuamF2YQ==) | `72.72% <0%> (-27.28%)` | `0% <0%> (ø)` | |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `75% <0%> (-25%)` | `0% <0%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/incubator-pinot/pull/3895/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=footer). Last update [ce551eb...1b87860](https://codecov.io/gh/apache/incubator-pinot/pull/3895?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org