You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2024/08/09 10:32:29 UTC

[PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

TyrantLucifer opened a new pull request, #7355:
URL: https://github.com/apache/seatunnel/pull/7355

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ### Purpose of this pull request
   
   Pre task for supporting flink multi table read/write.
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   
   No, this only the change about structure.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
   -->
   
   The existed test cases is enough.
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
     2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712574243


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) {
         this.kind = kind;
     }
 
+    public void setKind(RowKind kind) {

Review Comment:
   update all caller `getRowKind `、`setRowKind` to  `getKind `、`setKind` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712864081


##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/DataStreamTableInfo.java:
##########
@@ -18,20 +18,22 @@
 package org.apache.seatunnel.core.starter.flink.execution;
 
 import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
 
 import org.apache.flink.streaming.api.datastream.DataStream;
-import org.apache.flink.types.Row;
 
 import lombok.AllArgsConstructor;
 import lombok.Data;
 
+import java.util.List;
+
 @Data
 @AllArgsConstructor
 public class DataStreamTableInfo {
 
-    private DataStream<Row> dataStream;
+    private DataStream<SeaTunnelRow> dataStream;
 
-    private CatalogTable catalogTable;
+    private List<CatalogTable> catalogTable;

Review Comment:
   Might it be better to change to catalogTables instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712580747


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -50,7 +50,17 @@ public void setTableId(String tableId) {
         this.tableId = tableId;
     }
 
+    /**
+     * The method will be removed in the future, because the method name definition is not in
+     * accordance with the standard Pojo specification, the serialization framework cannot recognize
+     * it correctly.

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1713112880


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -50,7 +50,16 @@ public void setTableId(String tableId) {
         this.tableId = tableId;
     }
 
+    /**
+     * The method will be removed in the future, please use {@link #setKind(RowKind)} instanced of
+     * it.
+     */
+    @Deprecated
     public void setRowKind(RowKind kind) {
+        setKind(kind);
+    }

Review Comment:
   Consider it more carefully, why not change `kind` field to `rowKind`? cc @hailin0 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712558887


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) {
         this.kind = kind;
     }
 
+    public void setKind(RowKind kind) {

Review Comment:
   I think no need to do this. Unified the data pojo is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712870775


##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.java:
##########
@@ -42,9 +40,7 @@
 @Slf4j
 public class FlinkRowCollector implements Collector<SeaTunnelRow> {
 
-    private ReaderOutput<Row> readerOutput;
-
-    private final FlinkRowConverter rowSerialization;

Review Comment:
   Do we need to remove the FlinkRowConverter Class itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712907833


##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.java:
##########
@@ -42,9 +40,7 @@
 @Slf4j
 public class FlinkRowCollector implements Collector<SeaTunnelRow> {
 
-    private ReaderOutput<Row> readerOutput;
-
-    private final FlinkRowConverter rowSerialization;

Review Comment:
   Get your means, done, please review again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712558115


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) {
         this.kind = kind;
     }
 
+    public void setKind(RowKind kind) {

Review Comment:
   Should  be create `SeaTunnelRowWarpper` for flink engine adapter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712558314


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) {
         this.kind = kind;
     }
 
+    public void setKind(RowKind kind) {

Review Comment:
   `SeaTunnelRowWarpper` warp `SeaTunnelRow` object or extends SeaTunnelRow class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712664758


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -66,6 +75,10 @@ public RowKind getRowKind() {
         return this.kind;
     }

Review Comment:
   add `@Deprecated` to `getRowKind` method
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712576185


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -50,7 +50,17 @@ public void setTableId(String tableId) {
         this.tableId = tableId;
     }
 
+    /**
+     * The method will be removed in the future, because the method name definition is not in
+     * accordance with the standard Pojo specification, the serialization framework cannot recognize
+     * it correctly.

Review Comment:
   Please do not guarantee to developers that this class conforms to the POJO specification. Just tell devs use `setKind` is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712906351


##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.java:
##########
@@ -42,9 +40,7 @@
 @Slf4j
 public class FlinkRowCollector implements Collector<SeaTunnelRow> {
 
-    private ReaderOutput<Row> readerOutput;
-
-    private final FlinkRowConverter rowSerialization;

Review Comment:
   I'm sorry, is my expression has a problem, I mean the org.apache.seatunnel.translation.flink.serialization.FlinkRowConverter  responsible for conversion of classes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712574403


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) {
         this.kind = kind;
     }
 
+    public void setKind(RowKind kind) {

Review Comment:
   cc @EricJoy2048 @Hisoka-X @Carl-Zhou-CN 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712905056


##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.java:
##########
@@ -42,9 +40,7 @@
 @Slf4j
 public class FlinkRowCollector implements Collector<SeaTunnelRow> {
 
-    private ReaderOutput<Row> readerOutput;
-
-    private final FlinkRowConverter rowSerialization;

Review Comment:
   Not need, because the relevant metrics statistics and current limiting logic are all executed within this.



##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/DataStreamTableInfo.java:
##########
@@ -18,20 +18,22 @@
 package org.apache.seatunnel.core.starter.flink.execution;
 
 import org.apache.seatunnel.api.table.catalog.CatalogTable;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
 
 import org.apache.flink.streaming.api.datastream.DataStream;
-import org.apache.flink.types.Row;
 
 import lombok.AllArgsConstructor;
 import lombok.Data;
 
+import java.util.List;
+
 @Data
 @AllArgsConstructor
 public class DataStreamTableInfo {
 
-    private DataStream<Row> dataStream;
+    private DataStream<SeaTunnelRow> dataStream;
 
-    private CatalogTable catalogTable;
+    private List<CatalogTable> catalogTable;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712906351


##########
seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.java:
##########
@@ -42,9 +40,7 @@
 @Slf4j
 public class FlinkRowCollector implements Collector<SeaTunnelRow> {
 
-    private ReaderOutput<Row> readerOutput;
-
-    private final FlinkRowConverter rowSerialization;

Review Comment:
   I'm sorry, is my expression has a problem, I mean the org. Apache. Seatunnel. Translation. Flink. Serialization. FlinkRowConverter responsible for conversion of classes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#issuecomment-2282759877

   @hailin0 @Carl-Zhou-CN Please review again. Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712560892


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) {
         this.kind = kind;
     }
 
+    public void setKind(RowKind kind) {

Review Comment:
   To maintain compatibility, we annotate the duplicate old methods with @Deprecated and explain why they cannot be deleted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712573879


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) {
         this.kind = kind;
     }
 
+    public void setKind(RowKind kind) {

Review Comment:
   add `@Deprecated` to `getRowKind` method
   cc @TyrantLucifer 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1713120239


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -50,7 +50,16 @@ public void setTableId(String tableId) {
         this.tableId = tableId;
     }
 
+    /**
+     * The method will be removed in the future, please use {@link #setKind(RowKind)} instanced of
+     * it.
+     */
+    @Deprecated
     public void setRowKind(RowKind kind) {
+        setKind(kind);
+    }

Review Comment:
   Do you guys have any suggestions?
   @Carl-Zhou-CN @TyrantLucifer 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1713122173


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java:
##########
@@ -50,7 +50,16 @@ public void setTableId(String tableId) {
         this.tableId = tableId;
     }
 
+    /**
+     * The method will be removed in the future, please use {@link #setKind(RowKind)} instanced of
+     * it.
+     */
+    @Deprecated
     public void setRowKind(RowKind kind) {
+        setKind(kind);
+    }

Review Comment:
   I think this is a good approach if it achieves the same effect; modifying fields has less impact and avoids the issue of deprecated methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer merged PR #7355:
URL: https://github.com/apache/seatunnel/pull/7355


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org