[jira] [Comment Edited] (PIVOT-955) Flag in Skin to better draw flat components

["Sandro Martini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080852#comment-14080852 ] 

Sandro Martini edited comment on PIVOT-955 at 8/1/14 7:58 AM:
--------------------------------------------------------------

Committed revision 1614881 , with some changes: the Theme and Skin default configuration file (all others need to be updated, soon), and in some components (all others soon). And at least a dedicated configuration files even under tests.
At the moment this is a work-in-progress (wip), but to see the new behavior:
- set the flag themeIsFlat to true in the skin config file (by default TerraTheme_default.json )
- or negate che check inside the ComponentSkin themeIsFlat() method
and then run some Application, like Component Explorer, Color Scheme Builder, or any other ...

I think this is another small feature that could be useful to further generalize our default skin.



was (Author: smartini):
Committed revision 1614881 , with some changes: the Theme and Skin default configuration file (all others need to be updated, soon), and in some components (all others soon). And at least a dedicated configuration files even under tests.
At the moment this is a work-in-progress (wip), but to see the new behavior simply negate che check inside the ComponentSkin themeIsFlat() method, and run some Application, like Component Explorer, Color Scheme Builder, or any other ...

I think this is another small feature that could be useful to further generalize our default skin.


> Flag in Skin to better draw flat components
> -------------------------------------------
>
>                 Key: PIVOT-955
>                 URL: https://issues.apache.org/jira/browse/PIVOT-955
>             Project: Pivot
>          Issue Type: New Feature
>          Components: wtk-terra
>            Reporter: Sandro Martini
>            Assignee: Sandro Martini
>            Priority: Minor
>         Attachments: Pivot - ColorSchemeBuilder, some Components without border - prototype.png
>
>
> To easily implement custom styles more "flat", a new Skin (global) style property  themeIsFlat could be useful to tell the skin to not draw some elements like: borders around components, no gradients, no shadows.
> By default this is false, so the original behaviour is not changed.
> Check later if makes sense to add an additional property (but in any component) to let him override this global setting (but at the moment I don't think it would be so useful).
> Original proposal here: http://apache-pivot-developers.417237.n3.nabble.com/New-style-attribute-for-do-not-draw-border-in-components-for-2-1-td4026771.html
> and some discussion here:
> http://apache-pivot-users.399431.n3.nabble.com/Fwd-New-style-attribute-for-do-not-draw-border-in-components-for-2-1-td4022976.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)