You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/01 07:20:23 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #17387: [fix][test] Fix `ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure`

lhotari commented on code in PR #17387:
URL: https://github.com/apache/pulsar/pull/17387#discussion_r960302577


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java:
##########
@@ -60,7 +59,7 @@
 import org.testng.annotations.Test;
 
 @Slf4j
-@Test(groups = "quarantine")
+@Test(groups = "broker")

Review Comment:
   Was this added in #16605? before taking tests out of quarantine, it should be ensured that the test is not flaky any more. The problem fixed in this PR isn't about flakiness. Have you verified that ClientDeduplicationFailureTest is no more flaky?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org