You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/10/23 09:41:52 UTC

[PR] MINOR: Consumer-Internals clean up [kafka]

laglangyue opened a new pull request, #14614:
URL: https://github.com/apache/kafka/pull/14614

   I just arrived at the Kafka community and found some KAFKA-14246 through Jira. So I learned about this part of the code and made some modifications.
   I modified an incorrect link and code style
   
   ### Committer Checklist (excluded from commit message)
   - [x] Verify design and implementation 
   - [x] Verify test coverage and CI build status
   - [x] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Consumer-Internals clean up [kafka]

Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #14614:
URL: https://github.com/apache/kafka/pull/14614#issuecomment-1788942302

   > @laglangyue can you please rebase with trunk (there are conflicts right now) before we merge this in. Thanks!
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Consumer-Internals clean up [kafka]

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14614:
URL: https://github.com/apache/kafka/pull/14614#issuecomment-1788898213

   @laglangyue can you please rebase with trunk before we merge this in. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Consumer-Internals clean up [kafka]

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya merged PR #14614:
URL: https://github.com/apache/kafka/pull/14614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org