[GitHub] [james-project] vttranlina commented on a change in pull request #508: JAMES-3604 Improve RabbitMQ resiliency

[GitBox <gi...@apache.org>]

vttranlina commented on a change in pull request #508:
URL: https://github.com/apache/james-project/pull/508#discussion_r663631831



##########
File path: src/site/xdoc/server/config-rabbitmq.xml
##########
@@ -118,6 +118,11 @@
 
           <dt><strong>quorum.queues.replication.factor</strong></dt>
           <dd> Strictly positive integer. The replication factor to use when creating quorum queues.</dd>
+
+          <dt><strong>hostsr</strong></dt>

Review comment:
       `hosts`

##########
File path: server/apps/distributed-app/sample-configuration/rabbitmq.properties
##########
@@ -5,6 +5,10 @@
 # Mandatory
 uri=amqp://rabbitmq:5672

Review comment:
       Should we deprecate `uri` property? 
   When we declare `hosts` property, what is `uri` sense?
   Should we have only one property for endpoint declaration? IMO




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org