[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #9952: [Bug] [MASTER-9811]fix cmd param to overwrite global param when executing complement

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #9952:
URL: https://github.com/apache/dolphinscheduler/pull/9952#discussion_r867956223


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1953,4 +1958,36 @@ private boolean isNewProcessInstance() {
         }
     }
 
+    private void setGlobalParamIfCommanded(ProcessDefinition processDefinition, Map<String, String> cmdParam) {
+        // get start params from command param

Review Comment:
   I don't see the whole code, It's better to check the `cmdParam` in the begin, if the `cmdParam` is null, you can directly return. You can simplify the logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org