[jira] [Commented] (MENFORCER-436) Extension defined in .mvn/extensions.xml failing "requirePluginVersions" check

["Jeff Thomas (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MENFORCER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629245#comment-17629245 ] 

Jeff Thomas commented on MENFORCER-436:
---------------------------------------

Looking briefly into the code of the check I am just guessing here...

But if you are working with the maven-model, can't you just use the API `{{{}Plugin#isExtension(){}}}` to disable the check on those plugins...or provide an option to do so? 

Somewhere around here?
{code:java}
// pull out any we should skip
allPlugins =
  removeUncheckedPlugins( combineUncheckedPlugins( unCheckedPlugins, unCheckedPluginList ), allPlugins );{code}
TBH I don't know if a plugin loaded via the {{.mvn/extensions.xml}} automatically returns `{{{}true{}}}` on the {{isExtension()}} check. 

> Extension defined in .mvn/extensions.xml failing "requirePluginVersions" check
> ------------------------------------------------------------------------------
>
>                 Key: MENFORCER-436
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-436
>             Project: Maven Enforcer Plugin
>          Issue Type: Bug
>          Components: Standard Rules
>    Affects Versions: 3.1.0
>         Environment: Windows 10, JDK 11 (Temurin), Maven 3.8.6, Enforcer Plugin 3.1.0
>            Reporter: Jeff Thomas
>            Priority: Minor
>
> I have defined the "maven-git-versioning-extension' in .mvn/extensions.xml with an explicit version.
>  
> {{<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"}}
> {{ xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd">}}
> {{  <extension>}}
> {{    <groupId>me.qoomon</groupId>}}
> {{    <artifactId>maven-git-versioning-extension</artifactId>}}
> {{    <version>9.3.1</version>}}
> {{  </extension>}}
> {{</extensions>}}
> This extension is not referenced anywhere in my POM.
> However, the 'requirePluginVersions' check is failing during build.
> NOTE: I saw MENFORCER-133 which was similiar but is already closed.
> Currently I have the workaround to add "me.qoomon:maven-git-versioning-extension" to the "unCheckedPluginList" configuration option, but this is sort of annoying since we use this extension in almost all of our git projects. :)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)