You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mb...@apache.org on 2021/03/26 11:11:23 UTC

[asterixdb] 06/15: [NO ISSUE][EXT] Change default read buffer size to 8K

This is an automated email from the ASF dual-hosted git repository.

mblow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git

commit 45d20b7454c11e76a5767c53be4c66fc1b4d2457
Author: Murtadha Hubail <mh...@apache.org>
AuthorDate: Wed Mar 24 02:47:23 2021 +0300

    [NO ISSUE][EXT] Change default read buffer size to 8K
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    - Change default read buffer size for external datasets to 8K.
    
    Change-Id: I5f6108e07080c0a67f6f9496d90a4b49a14b081b
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10663
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Michael Blow <mb...@apache.org>
---
 .../java/org/apache/asterix/external/util/ExternalDataConstants.java  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
index 1e3ab45..fd5b269 100644
--- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
+++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
@@ -24,6 +24,8 @@ import java.util.Set;
 import java.util.function.LongSupplier;
 import java.util.function.Supplier;
 
+import org.apache.hyracks.util.StorageUtil;
+
 public class ExternalDataConstants {
 
     private ExternalDataConstants() {
@@ -257,7 +259,7 @@ public class ExternalDataConstants {
     /**
      * Size default values
      */
-    public static final int DEFAULT_BUFFER_SIZE = 4096;
+    public static final int DEFAULT_BUFFER_SIZE = StorageUtil.getIntSizeInBytes(8, StorageUtil.StorageUnit.KILOBYTE);
     public static final float DEFAULT_BUFFER_INCREMENT_FACTOR = 1.5F;
     public static final int DEFAULT_QUEUE_SIZE = 64;
     public static final int MAX_RECORD_SIZE = 32000000;