You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/02/28 16:13:06 UTC
Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
Updated validation of 'RAW' and 'BLOCK' disk resources.
Diffs
-----
src/common/resources.cpp a0c29246b3e3b377aabd0eb00ba16aa6bbd804e3
Diff: https://reviews.apache.org/r/65838/diff/1/
Testing
-------
`make check`
`sudo make check`
Thanks,
Benjamin Bannier
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 1, 2018, 2:57 p.m., Jan Schlicht wrote:
> > Please add this to `v1/resources.cpp` as well.
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198447
-----------------------------------------------------------
On March 2, 2018, 11:46 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 11:46 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
> src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
>
>
> Diff: https://reviews.apache.org/r/65838/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198447
-----------------------------------------------------------
Please add this to `v1/resources.cpp` as well.
- Jan Schlicht
On Feb. 28, 2018, 5:13 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 5:13 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp a0c29246b3e3b377aabd0eb00ba16aa6bbd804e3
>
>
> Diff: https://reviews.apache.org/r/65838/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198402
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65838]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2018, 8:13 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 8:13 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp a0c29246b3e3b377aabd0eb00ba16aa6bbd804e3
>
>
> Diff: https://reviews.apache.org/r/65838/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198547
-----------------------------------------------------------
src/common/resources.cpp
Lines 936 (patched)
<https://reviews.apache.org/r/65838/#comment278733>
s/Resource_DiskInfo_Source_Type_Name/Resource::DiskInfo::Source::Type_Name/
We usually call the `Type_Name` functions this way.
src/common/resources.cpp
Lines 943 (patched)
<https://reviews.apache.org/r/65838/#comment278734>
Ditto.
src/v1/resources.cpp
Lines 959 (patched)
<https://reviews.apache.org/r/65838/#comment278735>
Ditto.
src/v1/resources.cpp
Lines 966 (patched)
<https://reviews.apache.org/r/65838/#comment278736>
Ditto.
- Chun-Hung Hsiao
On March 2, 2018, 10:46 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 10:46 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
> src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
>
>
> Diff: https://reviews.apache.org/r/65838/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198630
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65838]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 5, 2018, 1:49 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated March 5, 2018, 1:49 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
> src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
>
>
> Diff: https://reviews.apache.org/r/65838/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198631
-----------------------------------------------------------
PASS: Mesos patch 65838 was successfully built and tested.
Reviews applied: `['65838']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65838
- Mesos Reviewbot Windows
On March 5, 2018, 1:49 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated March 5, 2018, 1:49 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
> src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
>
>
> Diff: https://reviews.apache.org/r/65838/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/
-----------------------------------------------------------
(Updated March 5, 2018, 2:49 p.m.)
Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
Changes
-------
Used nested types like pointed out by Chun.
Repository: mesos
Description
-------
Updated validation of 'RAW' and 'BLOCK' disk resources.
Diffs (updated)
-----
src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
Diff: https://reviews.apache.org/r/65838/diff/3/
Changes: https://reviews.apache.org/r/65838/diff/2-3/
Testing
-------
`make check`
`sudo make check`
Thanks,
Benjamin Bannier
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198531
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65838]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 2, 2018, 10:46 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 10:46 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
> src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
>
>
> Diff: https://reviews.apache.org/r/65838/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198546
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On March 2, 2018, 10:46 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 10:46 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
> src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
>
>
> Diff: https://reviews.apache.org/r/65838/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198522
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65838']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65838
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65838/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (151 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1233 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (41 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (49 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (93 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2591 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2617 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2476 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2500 ms total)
[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (475690 ms total)
[ PASSED ] 914 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65838/logs/mesos-tests-stderr.log):
```
I0302 12:28:10.742909 4664 slave.cpp:3879] Shutting down framework 75c34cc4-e2ca-473I0302 12:28:10.008934 8840 exec.cpp:162] Version: 1.6.0
I0302 12:28:10.040910 9480 exec.cpp:236] Executor registered on agent 75c34cc4-e2ca-473e-a49e-e385977d8fd9-S0
I0302 12:28:10.044936 3452 executor.cpp:176] Received SUBSCRIBED event
I0302 12:28:10.051934 3452 executor.cpp:180] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0302 12:28:10.052935 3452 executor.cpp:176] Received LAUNCH event
I0302 12:28:10.057937 3452 executor.cpp:648] Starting task fb3fc56f-9646-4373-9b2a-c781fd14abd3
I0302 12:28:10.147940 3452 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0302 12:28:10.706910 3452 executor.cpp:661] Forked command at 32
I0302 12:28:10.746909 8280 exec.cpp:445] Executor asked to shutdown
I0302 12:28:10.747911 3452 executor.cpp:176] Received SHUTDOWN event
I0302 12:28:10.747911 3452 executor.cpp:758] Shutting down
I0302 12:28:10.747911 3452 executor.cpp:868] Sending SIGTERM to process tree at pid 32
e-a49e-e385977d8fd9-0000
I0302 12:28:10.743909 4664 slave.cpp:6586] Shutting down executor 'fb3fc56f-9646-4373-9b2a-c781fd14abd3' of framework 75c34cc4-e2ca-473e-a49e-e385977d8fd9-0000 at executor(1)@10.3.1.11:56324
I0302 12:28:10.744910 4664 slave.cpp:922] Agent terminating
W0302 12:28:10.744910 4664 slave.cpp:3875] Ignoring shutdown framework 75c34cc4-e2ca-473e-a49e-e385977d8fd9-0000 because it is terminating
I0302 12:28:10.744910 5116 master.cpp:10357] Removing task fb3fc56f-9646-4373-9b2a-c781fd14abd3 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 75c34cc4-e2ca-473e-a49e-e385977d8fd9-0000 on agent 75c34cc4-e2ca-473e-a49e-e385977d8fd9-S0 at slave(398)@10.3.1.11:56303 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 12:28:10.748908 4664 containerizer.cpp:2338] Destroying container 5e1c075b-45e5-4fb9-a14c-568fbafa8cdc in RUNNING state
I0302 12:28:10.748908 5116 master.cpp:1306] Agent 75c34cc4-e2ca-473e-a49e-e385977d8fd9-S0 at slave(398)@10.3.1.11:56303 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0302 12:28:10.748908 4664 containerizer.cpp:2952] Transitioning the state of container 5e1c075b-45e5-4fb9-a14c-568fbafa8cdc from RUNNING to DESTROYING
I0302 12:28:10.749938 5116 master.cpp:3276] Disconnecting agent 75c34cc4-e2ca-473e-a49e-e385977d8fd9-S0 at slave(398)@10.3.1.11:56303 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 12:28:10.749938 7292 hierarchical.cpp:344] Removed framework 75c34cc4-e2ca-473e-a49e-e385977d8fd9-0000
I0302 12:28:10.749938 5116 master.cpp:3295] Deactivating agent 75c34cc4-e2ca-473e-a49e-e385977d8fd9-S0 at slave(398)@10.3.1.11:56303 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 12:28:10.749938 8116 hierarchical.cpp:766] Agent 75c34cc4-e2ca-473e-a49e-e385977d8fd9-S0 deactivated
I0302 12:28:10.750910 4664 launcher.cpp:156] Asked to destroy container 5e1c075b-45e5-4fb9-a14c-568fbafa8cdc
I0302 12:28:10.754910 8116 containerizer.cpp:2791] Container 5e1c075b-45e5-4fb9-a14c-568fbafa8cdc has exited
I0302 12:28:10.787914 7424 master.cpp:1149] Master terminating
I0302 12:28:10.789914 9188 hierarchical.cpp:609] Removed agent 75c34cc4-e2ca-473e-a49e-e385977d8fd9-S0
I0302 12:28:11.410006 520 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 2, 2018, 10:46 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 10:46 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
> src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
>
>
> Diff: https://reviews.apache.org/r/65838/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/
-----------------------------------------------------------
(Updated March 2, 2018, 11:46 a.m.)
Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
Changes
-------
Also update validation of v1 resources.
Repository: mesos
Description
-------
Updated validation of 'RAW' and 'BLOCK' disk resources.
Diffs (updated)
-----
src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
Diff: https://reviews.apache.org/r/65838/diff/2/
Changes: https://reviews.apache.org/r/65838/diff/1-2/
Testing
-------
`make check`
`sudo make check`
Thanks,
Benjamin Bannier
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198397
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65838']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65838
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65838/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (124 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1159 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (42 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (83 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2464 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2490 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2457 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2482 ms total)
[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (481882 ms total)
[ PASSED ] 914 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65838/logs/mesos-tests-stderr.log):
```
I0228 17:21:07.602572 9088 master.cpp:10258] Updating the state of task ad4c1906-4af3-4297-8c8e-3a48d4b76c0e of framework 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0228 17:21:07.602572 8792 slave.cpp:3879] Shutting down framework 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-0000
I0228 17:21:07.602572 8792 slave.cpp:6586] Shutting down executor 'ad4c1906-4af3-4297-8c8e-3a48d4b76c0e' of framework 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-0000 at executor(1)@10.3.1.5:60453
I0228 17:21:07.603581 8792 slave.cpp:922] Agent terminating
W0228 17:21:07.603581 8792 slave.cpp:3875] Ignoring shutdown framework 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-0000 because it is terminating
I0228 17:21:0I0228 17:21:06.900574 3544 exec.cpp:162] Version: 1.6.0
I0228 17:21:06.929574 1036 exec.cpp:236] Executor registered on agent 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-S0
I0228 17:21:06.934571 8392 executor.cpp:176] Received SUBSCRIBED event
I0228 17:21:06.939574 8392 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0228 17:21:06.939574 8392 executor.cpp:176] Received LAUNCH event
I0228 17:21:06.944573 8392 executor.cpp:648] Starting task ad4c1906-4af3-4297-8c8e-3a48d4b76c0e
I0228 17:21:07.025573 8392 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0228 17:21:07.566575 8392 executor.cpp:661] Forked command at 9672
I0228 17:21:07.604604 8900 exec.cpp:445] Executor asked to shutdown
I0228 17:21:07.605573 8392 executor.cpp:176] Received SHUTDOWN event
I0228 17:21:07.606578 8392 executor.cpp:758] Shutting down
I0228 17:21:07.606578 8392 executor.cpp:868] Sending SIGTERM to process tree at pid 97.605573 9088 master.cpp:10357] Removing task ad4c1906-4af3-4297-8c8e-3a48d4b76c0e with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-0000 on agent 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-S0 at slave(398)@10.3.1.5:60432 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 17:21:07.606578 7144 containerizer.cpp:2338] Destroying container a7769d0f-ccba-4b0a-8f25-bbb8f6f75331 in RUNNING state
I0228 17:21:07.607573 7144 containerizer.cpp:2952] Transitioning the state of container a7769d0f-ccba-4b0a-8f25-bbb8f6f75331 from RUNNING to DESTROYING
I0228 17:21:07.607573 7144 launcher.cpp:156] Asked to destroy container a7769d0f-ccba-4b0a-8f25-bbb8f6f75331
I0228 17:21:07.608572 9088 master.cpp:1306] Agent 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-S0 at slave(398)@10.3.1.5:60432 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0228 17:21:07.608572 9088 master.cpp:3276] Disconnecting agent 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-S0 at slave(398)@10.3.1.5:60432 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 17:21:07.609575 1444 hierarchical.cpp:344] Removed framework 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-0000
I0228 17:21:07.610571 9088 master.cpp:3295] Deactivating agent 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-S0 at slave(398)@10.3.1.5:60432 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 17:21:07.610571 5156 hierarchical.cpp:766] Agent 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-S0 deactivated
I0228 17:21:07.682708 1444 containerizer.cpp:2791] Container a7769d0f-ccba-4b0a-8f25-bbb8f6f75331 has exited
I0228 17:21:07.713708 9532 master.cpp:1149] Master terminating
I0228 17:21:07.716713 7452 hierarchical.cpp:609] Removed agent 7c635dbc-0475-4a94-90ee-67d4ee21ccb1-S0
I0228 17:21:08.437150 9756 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Feb. 28, 2018, 4:13 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 4:13 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp a0c29246b3e3b377aabd0eb00ba16aa6bbd804e3
>
>
> Diff: https://reviews.apache.org/r/65838/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>