You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@icorps.com> on 2012/07/27 13:34:57 UTC
Re: Review Request: Rave-733: Fixed issue with displaying wrong display name
/ username in the top left title welcome message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6136/
-----------------------------------------------------------
(Updated July 27, 2012, 11:34 a.m.)
Review request for rave.
Summary (updated)
-----------------
Rave-733: Fixed issue with displaying wrong display name / username in the top left title welcome message
Description
-------
Fixes the issue where the wrong display name is shown in the top left page title welcome message.
Now it always reads the display name/username of the person who is logged in, instead of the person's page you are looking at.
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1365541
Diff: https://reviews.apache.org/r/6136/diff/
Testing
-------
Thanks,
Daniel Gornstein
Re: Review Request: Rave-733: Fixed issue with displaying wrong display name
/ username in the top left title welcome message
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6136/#review9552
-----------------------------------------------------------
Ship it!
LGTM!
- Anthony Carlucci
On July 27, 2012, 11:34 a.m., Daniel Gornstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6136/
> -----------------------------------------------------------
>
> (Updated July 27, 2012, 11:34 a.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Fixes the issue where the wrong display name is shown in the top left page title welcome message.
>
> Now it always reads the display name/username of the person who is logged in, instead of the person's page you are looking at.
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1365541
>
> Diff: https://reviews.apache.org/r/6136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Gornstein
>
>